Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of empty metadata when uploading data files #207

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

shoeffner
Copy link
Collaborator

Relates to datalad/datalad-dataverse#320: Handles "empty" metadata and is an alternative to datalad/datalad-dataverse#322.

@pdurbin pdurbin changed the title Fix handling of empty metadata Fix handling of empty metadata when uploading data files Jul 24, 2024
@pdurbin
Copy link
Member

pdurbin commented Jul 24, 2024

At a high level, this seems like a good fix. The JSON should be optional.

Copy link
Member

@JR-1991 JR-1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@JR-1991 JR-1991 merged commit 0e40e0b into gdcc:fix-form-data Jul 26, 2024
1 check passed
@adswa
Copy link

adswa commented Aug 27, 2024

many thanks again for this fix :) Is there by chance a pyDataverse release upcoming? Otherwise, I'll let datalad-dataverse depend on a development version from github for the time being. :)

@pdurbin
Copy link
Member

pdurbin commented Aug 27, 2024

@adswa hi! I'll defer to @JR-1991 on the timing of the release but it should be 0.3.4. I just assigned that milestone to this PR (which was a PR to #203 which also has that milestone).

I don't see any problem with using a dev version, in the meantime.

@JR-1991
Copy link
Member

JR-1991 commented Aug 27, 2024

@adswa - Once the final two pull requests are merged and all issues are resolved within the milestone, we will be all set to release the next version 0.3.4 of pyDataverse. Both are relatively small and I am confident that we will have the release out very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants