feat: replace warnings with markdown printouts #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbelak-dtml
force-pushed
the
feat/markdown-instead-of-warnings
branch
4 times, most recently
from
f92c64d
to
32ce9b5
Compare
lukany
requested changes
Aug 21, 2023
edvart/report_sections/timeseries_analysis/seasonal_decomposition.py
Outdated
Show resolved
Hide resolved
edvart/report_sections/timeseries_analysis/time_analysis_plot.py
Outdated
Show resolved
Hide resolved
mbelak-dtml
force-pushed
the
feat/markdown-instead-of-warnings
branch
from
32ce9b5
to
301705b
Compare
lukany
previously approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Optional suggestion in #94 (comment).
However, it's already good enough to merge from my side.
mbelak-dtml
force-pushed
the
feat/markdown-instead-of-warnings
branch
from
9239fd0
to
5ff12ff
Compare
lukany
approved these changes
Sep 4, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
Remove a warning that a categorical column with many categories is used for coloring of TS line plot. Following #94, which removes most of the warnings, the warning here is removed since it does not bring relevant information to the user (the user can see that there are many colors), and makes the final reports ugly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41