Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration CLI by making packages external #3582

Merged
merged 20 commits into from
Dec 11, 2024
Merged

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Dec 10, 2024

Proposed changes

closes #3578
closes #3581

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) December 10, 2024 09:14
@github-actions github-actions bot added the 🏗foundations Changes inside foundations folder label Dec 10, 2024
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-migration-tool

@mfranzke
Copy link
Member

@nmerget this might only fix #3581 instead of #3578, doesn't it? Or do you actually expect both to be fixed?

@nmerget
Copy link
Member Author

nmerget commented Dec 10, 2024

It should fix both, yes

@mfranzke
Copy link
Member

It should fix both, yes

you're the best

@mfranzke
Copy link
Member

mfranzke commented Dec 10, 2024

It should fix both, yes

@nmerget düümm düümmm

node:internal/modules/esm/resolve:854
  throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base), null);
        ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'commander' imported from /Users/maximilianfranzke/.npm/_npx/0d1f7af59eae6113/node_modules/@db-ui/foundations/build/index.js
    at packageResolve (node:internal/modules/esm/resolve:854:9)
    at moduleResolve (node:internal/modules/esm/resolve:927:18)
    at defaultResolve (node:internal/modules/esm/resolve:1169:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:227:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:87:39)
    at link (node:internal/modules/esm/module_job:86:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}

Node.js v20.16.0

@nmerget
Copy link
Member Author

nmerget commented Dec 10, 2024

We need to publish the migration under another name. The problem is that we need dependencies from package.json to install something like commander in npx. But we shouldn't install it for @db-ui/foundations

@mfranzke
Copy link
Member

mfranzke commented Dec 10, 2024

We need to publish the migration under another name. The problem is that we need dependencies from package.json to install something like commander in npx. But we shouldn't install it for @db-ui/foundations

be my guest. Judged by the statistics you haven't opened another repo (or at least another package) this week (who are you and what did you do to @nmerget btw.?). I would assume that we could keep it in this repo, but call it @db-ui/migration than ?

@mfranzke mfranzke marked this pull request as draft December 10, 2024 10:56
auto-merge was automatically disabled December 10, 2024 10:56

Pull request was converted to draft

@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🚢📀cicd Changes inside .github folder labels Dec 10, 2024
# Conflicts:
#	package-lock.json
#	packages/foundations/package.json
@mfranzke mfranzke mentioned this pull request Dec 10, 2024
5 tasks
@mfranzke mfranzke changed the title fix: migration cli by making packages external fix: migration CLI by making packages external Dec 10, 2024
@nmerget nmerget marked this pull request as ready for review December 11, 2024 08:24
@nmerget nmerget requested a review from mfranzke December 11, 2024 08:24
@nmerget nmerget enabled auto-merge (squash) December 11, 2024 09:11
@nmerget nmerget merged commit 595f7f5 into main Dec 11, 2024
138 checks passed
@nmerget nmerget deleted the fix-migration-tool branch December 11, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚢📀cicd Changes inside .github folder 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration error: ERR_MODULE_NOT_FOUND Migration error: Dynamic require of "node:events" is not supported
2 participants