-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT-1821-Updated the issuance schema and the request json to the latest #183
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,11 +2,90 @@ | |
| "document": { | ||
| "transportDocumentReference": "TRANSPORT_DOCUMENT_REFERENCE_PLACEHOLDER", | ||
| "shippingInstructionsReference": "SHIPPING_INSTRUCTION_REFERENCE_PLACEHOLDER", | ||
| "transportDocumentStatus": "ISSUED", | ||
| "transportDocumentTypeCode": "BOL", | ||
| "isShippedOnBoardType": true, | ||
| "freightPaymentTermCode": "PRE", | ||
| "isElectronic": true, | ||
| "isToOrder": false, | ||
| "displayedNameForPlaceOfReceipt": [ | ||
| "Strawinskylaan 4117" | ||
| ], | ||
| "displayedNameForPortOfLoad": [ | ||
| "Strawinskylaan 4117" | ||
| ], | ||
| "displayedNameForPortOfDischarge": [ | ||
| "Strawinskylaan 4117" | ||
| ], | ||
| "displayedNameForPlaceOfDelivery": [ | ||
| "Strawinskylaan 4117" | ||
| ], | ||
| "shippedOnBoardDate": "2020-12-12", | ||
| "displayedShippedOnBoardReceivedForShipment": "Received for Shipment CMA CGM CONCORDE 28-Jul-2022 CMA CGM Agences France SAS As agents for the Carrier", | ||
| "termsAndConditions": "Any reference in...", | ||
| "receiptTypeAtOrigin": "CY", | ||
| "deliveryTypeAtDestination": "CY", | ||
| "cargoMovementTypeAtOrigin": "FCL", | ||
| "cargoMovementTypeAtDestination": "FCL", | ||
| "issueDate": "2020-12-12", | ||
| "serviceContractReference": "HHL51800000", | ||
| "contractQuotationReference": "12345", | ||
| "declaredValue": 1231.1, | ||
| "declaredValueCurrency": "DKK", | ||
| "carrierCode": "MMCU", | ||
| "carrierCodeListProvider": "NMFTA", | ||
| "carrierClauses": [ | ||
| "It is not allowed to..." | ||
| ], | ||
| "numberOfRiderPages": 2, | ||
| "transports": { | ||
| "plannedArrivalDate": "2024-06-07", | ||
| "plannedDepartureDate": "2024-06-03", | ||
| "preCarriageBy": "RAIL", | ||
| "onCarriageBy": "TRUCK", | ||
| "placeOfReceipt": { | ||
| "locationName": "Hamburg", | ||
| "UNLocationCode": "DEHAM" | ||
| }, | ||
| "portOfLoading": { | ||
| "locationName": "Hamburg", | ||
| "UNLocationCode": "DEHAM" | ||
| }, | ||
| "portOfDischarge": { | ||
| "locationName": "Hamburg", | ||
| "UNLocationCode": "DEHAM" | ||
| }, | ||
| "placeOfDelivery": { | ||
| "locationName": "Hamburg", | ||
| "UNLocationCode": "DEHAM" | ||
| }, | ||
| "onwardInlandRouting": { | ||
| "locationName": "Hamburg", | ||
| "UNLocationCode": "DEHAM" | ||
| }, | ||
| "vesselVoyages": [ | ||
| { | ||
| "vesselName": "King of the Seas", | ||
| "carrierExportVoyageNumber": "2103S", | ||
| "universalExportVoyageReference": "2103N" | ||
| } | ||
| ] | ||
| }, | ||
| "charges": [ | ||
| { | ||
| "chargeName": "Documentation fee - Destination", | ||
| "currencyAmount": 1012.12, | ||
| "currencyCode": "DKK", | ||
| "paymentTermCode": "PRE", | ||
| "calculationBasis": "Per day", | ||
| "unitPrice": 3456.6, | ||
| "quantity": 34.4 | ||
| } | ||
| ], | ||
| "placeOfIssue": { | ||
| "locationName": "Port of Amsterdam", | ||
| "UNLocationCode": "NLAMS" | ||
| }, | ||
| "invoicePayableAt": { | ||
| "UNLocationCode": "DKAAR" | ||
| }, | ||
|
|
@@ -28,10 +107,10 @@ | |
| }, | ||
| "consignee": { | ||
| "partyName": "CONSIGNEE_LEGAL_NAME_PLACEHOLDER", | ||
| "partyCodes": [ | ||
| "identifyingCodes": [ | ||
| { | ||
| "partyCode": "CONSIGNEE_PARTY_CODE_PLACEHOLDER", | ||
| "codeListProvider": "EPUI", | ||
| "partyCode": "CONSIGNEE_PARTY_CODE_PLACEHOLDER", | ||
| "codeListName": "CONSIGNEE_CODE_LIST_NAME_PLACEHOLDER" | ||
| } | ||
| ], | ||
|
|
@@ -42,17 +121,6 @@ | |
| } | ||
| ] | ||
| }, | ||
| "notifyParties": [ | ||
| { | ||
| "partyName": "DCSA CTK", | ||
| "partyContactDetails": [ | ||
| { | ||
| "name": "DCSA test person", | ||
| "email": "[email protected]" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "issuingParty": { | ||
| "partyName": "Hyundai", | ||
| "address": { | ||
|
|
@@ -68,6 +136,17 @@ | |
| } | ||
| ] | ||
| }, | ||
| "notifyParties": [ | ||
| { | ||
| "partyName": "DCSA CTK", | ||
| "partyContactDetails": [ | ||
| { | ||
| "name": "DCSA test person", | ||
| "email": "[email protected]" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "other": [ | ||
| { | ||
| "party": { | ||
|
|
@@ -102,65 +181,26 @@ | |
| ], | ||
| "utilizedTransportEquipments": [ | ||
| { | ||
| "equipment": { | ||
| "equipmentReference": "NARU3472484", | ||
| "ISOEquipmentCode": "22G1" | ||
| }, | ||
| "isShipperOwned": false, | ||
| "seals": [ | ||
| { | ||
| "number": "DCSA-CTK-1234" | ||
| } | ||
| ], | ||
| "cargoGrossWeight": 12000.0, | ||
| "cargoGrossWeightUnit": "KGM", | ||
| "equipment": { | ||
| "ISOEquipmentCode": "22G1", | ||
| "equipmentReference": "NARU3472484" | ||
| } | ||
| } | ||
| ], | ||
| "isShippedOnBoardType": true, | ||
| "transportDocumentStatus": "ISSUED", | ||
| "cargoMovementTypeAtOrigin": "FCL", | ||
| "cargoMovementTypeAtDestination": "FCL", | ||
| "receiptTypeAtOrigin": "CY", | ||
| "deliveryTypeAtDestination": "CY", | ||
| "shippedOnBoardDate": "2023-12-19", | ||
| "termsAndConditions": "You agree that this transport document exist is name only for the sake of\ntesting your conformance with the DCSA EBL API. This transport document is NOT backed\nby a real shipment with ANY carrier and NONE of the requested services will be\ncarried out in real life.\n\nUnless required by applicable law or agreed to in writing, DCSA provides\nthis JSON data on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF\nANY KIND, either express or implied, including, without limitation, any\nwarranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY,\nor FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for\ndetermining the appropriateness of using or redistributing this JSON\ndata and assume any risks associated with Your usage of this data.\n\nIn no event and under no legal theory, whether in tort (including negligence),\ncontract, or otherwise, unless required by applicable law (such as deliberate\nand grossly negligent acts) or agreed to in writing, shall DCSA be liable to\nYou for damages, including any direct, indirect, special, incidental, or\nconsequential damages of any character arising as a result of this terms or conditions\nor out of the use or inability to use the provided JSON data (including but not limited\nto damages for loss of goodwill, work stoppage, computer failure or malfunction, or any\nand all other commercial damages or losses), even if DCSA has been advised of the\npossibility of such damages.\n", | ||
| "carrierCode": "HMM", | ||
| "carrierCodeListProvider": "SMDG", | ||
| "charges": [ | ||
| { | ||
| "chargeName": "Fictive transport document fee", | ||
| "currencyAmount": 1.0, | ||
| "currencyCode": "EUR", | ||
| "paymentTermCode": "COL", | ||
| "calculationBasis": "Per transport document", | ||
| "unitPrice": 1.0, | ||
| "quantity": 1 | ||
| ] | ||
| } | ||
| ], | ||
| "transports": { | ||
| "plannedDepartureDate": "2023-12-19", | ||
| "plannedArrivalDate": "2023-12-21", | ||
| "portOfLoading": { | ||
| "UNLocationCode": "DKAAR" | ||
| }, | ||
| "portOfDischarge": { | ||
| "UNLocationCode": "DEBRV" | ||
| }, | ||
| "vesselVoyages": [ | ||
| { | ||
| "vesselName": "HMM Algeciras", | ||
| "carrierExportVoyageNumber": "402E" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| "issueTo": { | ||
| "sendToPlatform": "SEND_TO_PLATFORM_PLACEHOLDER", | ||
| "partyName": "ISSUE_TO_LEGAL_NAME_PLACEHOLDER", | ||
| "partyCodes": [ | ||
| "sendToPlatform": "SEND_TO_PLATFORM_PLACEHOLDER", | ||
| "identifyingCodes": [ | ||
| { | ||
| "partyCode": "ISSUE_TO_PARTY_CODE_PLACEHOLDER", | ||
| "codeListProvider": "EPUI", | ||
| "partyCode": "ISSUE_TO_PARTY_CODE_PLACEHOLDER", | ||
| "codeListName": "ISSUE_TO_CODE_LIST_NAME_PLACEHOLDER" | ||
| } | ||
| ] | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@palatsangeetha: The
EPUIcode is no longer valid for this field. I am a bit surprised that the CTK is giving green for this. I suspect one of the eBL conditional validations are not up to date (the same code is used for eBL, ISS, and PINT, so the bug is in all the standards).@gj0dcsa: FYI in case you were planning to deploy it and someone test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nt-gt for pointing this out. I will update the request with example values from the latest API spec.