fix(types): Conform lib.deno_web.d.ts to lib.dom.d.ts and lib.webworker.d.ts #24599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this also fix? |
bartlomieju
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Thanks for working on this. Could you please add some tests like I did in #24489 to ensure we don't regress again?
petamoriken
force-pushed
the
fix/conform-types
branch
from
537d04b
to
1695f7a
Compare
|
@petamoriken do you need any help with this PR? I'd like to land it before v1.45.3 release that will happen on Monday, July 22nd. |
|
@bartlomieju Finally, I am going to add type aliases for users who refer to old types. It shouldn't take that long. |
petamoriken
commented
Jul 22, 2024
Comment on lines
-610
to
-625
| /** @category Streams */ | ||
| declare interface ReadableStreamBYOBReadDoneResult<V extends ArrayBufferView> { | ||
| done: true; | ||
| value?: V; | ||
| } | ||
|
|
||
| /** @category Streams */ | ||
| declare interface ReadableStreamBYOBReadValueResult<V extends ArrayBufferView> { | ||
| done: false; | ||
| value: V; | ||
| } | ||
|
|
||
| /** @category Streams */ | ||
| declare type ReadableStreamBYOBReadResult<V extends ArrayBufferView> = | ||
| | ReadableStreamBYOBReadDoneResult<V> | ||
| | ReadableStreamBYOBReadValueResult<V>; |
There was a problem hiding this comment.
It can be reland when supported by upstream (microsoft/TypeScript-DOM-lib-generator#1676)
| readonly readable: ReadableStream<string>; | ||
| readonly writable: WritableStream<BufferSource>; | ||
| readonly [Symbol.toStringTag]: string; |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24578
Fix #21981