Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Conform lib.deno_web.d.ts to lib.dom.d.ts and lib.webworker.d.ts #24599

Merged
merged 27 commits into from
Jul 22, 2024
Merged

fix(types): Conform lib.deno_web.d.ts to lib.dom.d.ts and lib.webworker.d.ts #24599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b92ba6e
patch streams in lib.dom.d.ts and lib.webworker.d.ts
petamoriken Jul 16, 2024
e149e34
conform lib.deno_web.d.ts streams
petamoriken Jul 16, 2024
0fc03b7
conform lib.deno_web.d.ts encoding
petamoriken Jul 16, 2024
3e92ba7
delete `Symbol.toStringTag` and wait for upstream support
petamoriken Jul 16, 2024
d76ae68
tweak prototype to readonly
petamoriken Jul 16, 2024
b7f56fa
format
petamoriken Jul 16, 2024
466e9fd
tweak
petamoriken Jul 16, 2024
94b5260
patch events in lib.dom.d.ts and lib.webworker.d.ts
petamoriken Jul 16, 2024
3589358
conform lib.deno_web.d.ts streams again
petamoriken Jul 16, 2024
27a82bf
conform lib.deno_web.d.ts events and platform
petamoriken Jul 16, 2024
8f8547d
conform lib.deno_web.d.ts file
petamoriken Jul 16, 2024
663cc4e
tweak
petamoriken Jul 16, 2024
51c0261
replace `Promise` with `PromiseLike`
petamoriken Jul 16, 2024
1bfdd98
fix
petamoriken Jul 16, 2024
101ecdd
Revert constructor types
petamoriken Jul 21, 2024
6f58313
Merge branch 'main' into fix/conform-types
petamoriken Jul 21, 2024
1e5fdeb
Fix CompressionStream/DecompressionStream types
petamoriken Jul 21, 2024
cae8e75
fix
petamoriken Jul 21, 2024
1395293
add `ReadableStream.from` spec test
petamoriken Jul 21, 2024
1695f7a
refactor
petamoriken Jul 21, 2024
2f7ff82
Merge branch 'main' into fix/conform-types
petamoriken Jul 21, 2024
3144ade
fix
petamoriken Jul 21, 2024
a7e70c0
revert `ReadableBYOBReader` constructor type
petamoriken Jul 21, 2024
3660927
revert `EventListener` types
petamoriken Jul 21, 2024
4b95535
add deprecated type aliases
petamoriken Jul 22, 2024
d77820b
format
petamoriken Jul 22, 2024
1876ebe
Merge branch 'main' into fix/conform-types
petamoriken Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions cli/tsc/dts/lib.dom.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1930,11 +1930,16 @@ interface TrackEventInit extends EventInit {
track?: TextTrack | null;
}

interface TransformerCancelCallback {
(reason: any): void | PromiseLike<void>;
}

interface Transformer<I = any, O = any> {
flush?: TransformerFlushCallback<O>;
readableType?: undefined;
start?: TransformerStartCallback<O>;
transform?: TransformerTransformCallback<I, O>;
cancel?: TransformerCancelCallback;
writableType?: undefined;
}

Expand Down Expand Up @@ -5847,6 +5852,8 @@ declare var CompositionEvent: {

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CompressionStream) */
interface CompressionStream extends GenericTransformStream {
readonly readable: ReadableStream<Uint8Array>;
readonly writable: WritableStream<BufferSource>;
}

declare var CompressionStream: {
Expand Down Expand Up @@ -6744,6 +6751,8 @@ declare var DataTransferItemList: {

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/DecompressionStream) */
interface DecompressionStream extends GenericTransformStream {
readonly readable: ReadableStream<Uint8Array>;
readonly writable: WritableStream<BufferSource>;
}

declare var DecompressionStream: {
Expand Down Expand Up @@ -8873,9 +8882,7 @@ declare var GamepadHapticActuator: {
};

interface GenericTransformStream {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CompressionStream/readable) */
readonly readable: ReadableStream;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CompressionStream/writable) */
readonly writable: WritableStream;
}

Expand Down Expand Up @@ -18816,22 +18823,27 @@ interface ReadableStream<R = any> {

declare var ReadableStream: {
prototype: ReadableStream;
new(underlyingSource: UnderlyingByteSource, strategy?: { highWaterMark?: number }): ReadableStream<Uint8Array>;
new(underlyingSource: UnderlyingByteSource, strategy?: { highWaterMark?: number; size?: undefined }): ReadableStream<Uint8Array>;
new<R = any>(underlyingSource: UnderlyingDefaultSource<R>, strategy?: QueuingStrategy<R>): ReadableStream<R>;
new<R = any>(underlyingSource?: UnderlyingSource<R>, strategy?: QueuingStrategy<R>): ReadableStream<R>;
from<R>(asyncIterable: AsyncIterable<R> | Iterable<R | PromiseLike<R>>): ReadableStream<R>;
};

interface ReadableStreamBYOBReaderReadOptions {
min?: number;
}

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStreamBYOBReader) */
interface ReadableStreamBYOBReader extends ReadableStreamGenericReader {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStreamBYOBReader/read) */
read<T extends ArrayBufferView>(view: T): Promise<ReadableStreamReadResult<T>>;
read<T extends ArrayBufferView>(view: T, options?: ReadableStreamBYOBReaderReadOptions): Promise<ReadableStreamReadResult<T>>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStreamBYOBReader/releaseLock) */
releaseLock(): void;
}

declare var ReadableStreamBYOBReader: {
prototype: ReadableStreamBYOBReader;
new(stream: ReadableStream): ReadableStreamBYOBReader;
new(stream: ReadableStream<Uint8Array>): ReadableStreamBYOBReader;
};

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStreamBYOBRequest) */
Expand Down
22 changes: 17 additions & 5 deletions cli/tsc/dts/lib.webworker.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,11 +717,16 @@ interface TextEncoderEncodeIntoResult {
written: number;
}

interface TransformerCancelCallback {
(reason: any): void | PromiseLike<void>;
}

interface Transformer<I = any, O = any> {
flush?: TransformerFlushCallback<O>;
readableType?: undefined;
start?: TransformerStartCallback<O>;
transform?: TransformerTransformCallback<I, O>;
cancel?: TransformerCancelCallback;
writableType?: undefined;
}

Expand Down Expand Up @@ -1807,6 +1812,8 @@ declare var CloseEvent: {

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CompressionStream) */
interface CompressionStream extends GenericTransformStream {
readonly readable: ReadableStream<Uint8Array>;
readonly writable: WritableStream<BufferSource>;
}

declare var CompressionStream: {
Expand Down Expand Up @@ -2258,6 +2265,8 @@ declare var DOMStringList: {

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/DecompressionStream) */
interface DecompressionStream extends GenericTransformStream {
readonly readable: ReadableStream<Uint8Array>;
readonly writable: WritableStream<BufferSource>;
}

declare var DecompressionStream: {
Expand Down Expand Up @@ -3082,9 +3091,7 @@ declare var FormData: {
};

interface GenericTransformStream {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CompressionStream/readable) */
readonly readable: ReadableStream;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CompressionStream/writable) */
readonly writable: WritableStream;
}

Expand Down Expand Up @@ -4875,22 +4882,27 @@ interface ReadableStream<R = any> {

declare var ReadableStream: {
prototype: ReadableStream;
new(underlyingSource: UnderlyingByteSource, strategy?: { highWaterMark?: number }): ReadableStream<Uint8Array>;
new(underlyingSource: UnderlyingByteSource, strategy?: { highWaterMark?: number; size?: undefined }): ReadableStream<Uint8Array>;
new<R = any>(underlyingSource: UnderlyingDefaultSource<R>, strategy?: QueuingStrategy<R>): ReadableStream<R>;
new<R = any>(underlyingSource?: UnderlyingSource<R>, strategy?: QueuingStrategy<R>): ReadableStream<R>;
from<R>(asyncIterable: AsyncIterable<R> | Iterable<R | PromiseLike<R>>): ReadableStream<R>;
};

interface ReadableStreamBYOBReaderReadOptions {
min?: number;
}

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStreamBYOBReader) */
interface ReadableStreamBYOBReader extends ReadableStreamGenericReader {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStreamBYOBReader/read) */
read<T extends ArrayBufferView>(view: T): Promise<ReadableStreamReadResult<T>>;
read<T extends ArrayBufferView>(view: T, options?: ReadableStreamBYOBReaderReadOptions): Promise<ReadableStreamReadResult<T>>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStreamBYOBReader/releaseLock) */
releaseLock(): void;
}

declare var ReadableStreamBYOBReader: {
prototype: ReadableStreamBYOBReader;
new(stream: ReadableStream): ReadableStreamBYOBReader;
new(stream: ReadableStream<Uint8Array>): ReadableStreamBYOBReader;
};

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStreamBYOBRequest) */
Expand Down
Loading