Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15565 breadcrumb data changes #1744

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

timcosgrove
Copy link
Contributor

@timcosgrove timcosgrove commented Oct 10, 2023

Description

Related to #15565

The changes to breadcrumb data that are implemented in department-of-veterans-affairs/va.gov-cms#15572 require some changes to Content Build to conform to the new data model.

Testing done & Screenshots

  • Checked broken links and other tests, made sure that build succeeded
  • Checked examples of every content type against their production equivalents to make sure they remained consistent
  • Some links that were unnecessarily dependent on the breadcrumbs data shifted to a more stable mechanism

QA steps

Links to example pages from each affected content type. Unless noted, what should be checked is the breadcrumb.

Events

Specifically check that the 'See more events' link works

FAQ

VAMC Facility

Story

Staff Profile

Press Release

Check both breadcrumb and 'See all press releases' link.

Q & A

Step by Step

Resources and Support Detail Page

VA Form

Acceptance criteria

  • All pages listed have identical breadcrumbs and if indicated other links

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@timcosgrove timcosgrove force-pushed the VACMS-15565-breadcrumb_data_changes branch from 969ca37 to d26ed3f Compare October 10, 2023 21:01
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-15565-breadcrumb_data_changes October 10, 2023 22:11 Inactive
@timcosgrove timcosgrove changed the title DNM: VACMS-15565 breadcrumb data changes VACMS-15565 breadcrumb data changes Oct 20, 2023
@tjheffner tjheffner marked this pull request as ready for review October 20, 2023 20:14
@tjheffner tjheffner requested review from a team as code owners October 20, 2023 20:14
@tjheffner tjheffner self-requested a review October 20, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants