-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-15565: reenable breadcrumb modules. #15572
Conversation
2eb8a6d
to
ce1b634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that @ndouglas, this env was mistakenly rebuilt with the wrong front end version when you checked it prior. The "default" tag for this environment is 3 weeks old, so it was a little out of date when you peeked. 😅 I re-built it using the latest |
@tjheffner NP, at least you know I'm awake 😎 |
@ndouglas breadcrumbs should be built against the correct environment to review at your convenience. All CI checks are passing 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All pages' breadcrumbs were identical and the "See more events" and "See more news releases" links worked.
Broken links:
This does not appear to be connected to any issue with breadcrumbs AFAICT. |
Co-authored-by: Tanner Heffner <[email protected]>
Description
Related to #15565
This makes changes to the breadcrumb data model to support breadcrumbs in JSON:API, which is necessary for AP. It is connected to a content-build PR which makes changes in how it references some breadcrumb data.
Testing done & Screenshots
QA steps
Links to example pages from each affected content type. Unless noted, what should be checked is the breadcrumb.
Note that what we are checking here is Content Build output.
Events
Specifically check that the 'See more events' link works
FAQ
VAMC Facility
Story
Staff Profile
Press Release
Check both breadcrumb and 'See all press releases' link.
Q & A
Step by Step
Resources and Support Detail Page
VA Form
Acceptance criteria
Definition of done