Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travel Pay/update travel pay entry #2385

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

liztownd
Copy link
Contributor

@liztownd liztownd commented Dec 11, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • (Summarize the changes that have been made to the platform)
    Updated the Travel Pay app entry in registry.json

  • (What is the solution, why is this the solution)
    Changing the rootUrl for our application to allow for future features.
    Old URL: my-health/travel-claim-status
    New URL: my-health/travel-pay

  • (Which team do you work for, does your team own the maintenance of this component?)
    Travel Pay

Related issue(s)

Testing done

  • Describe the steps required to verify your changes are working as expected
  • AFTER vets-website PR is merged: Login with and MHV user. Make sure the travel_pay_power_switch feature toggle is turned on. Visit {base_va.gov_url}/my-health/travel-pay/claims/ and verify that the page loads.

Screenshots

N/A

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)
registry.json entry for Travel Pay app

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link

@IGallupSoCo IGallupSoCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liztownd liztownd marked this pull request as ready for review December 13, 2024 13:32
@liztownd liztownd merged commit 3f589d7 into main Dec 16, 2024
27 checks passed
@liztownd liztownd deleted the liz/update-travel-pay-url branch December 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants