Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travel Pay/change root url #33498

Merged
merged 12 commits into from
Dec 16, 2024
Merged

Travel Pay/change root url #33498

merged 12 commits into from
Dec 16, 2024

Conversation

liztownd
Copy link
Contributor

@liztownd liztownd commented Dec 11, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:
    N/A

  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

NOTE:

  • While I am not "renaming" a folder, I am changing the manifest.json and rootUrl for our application, so I will have a content-build PR to merge as well.
  • Link to content-build PR
    PR #2385

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • (Summarize the changes that have been made to the platform)
    Changing the rootUrl for our application to allow for future features.

Old URL: my-health/travel-claim-status
New URL: my-health/travel-pay

Also adding a sub-route /claims to consolidate all travel claim related pages. The root path (/) will redirect (using React Router <Redirect> component) within the mounted Travel Pay app.

The application has not yet been publicly rolled out, so a server-side redirect is not necessary.

  • (What is the solution, why is this the solution)
    The initial rootUrl for the application as a whole was travel-claim-status but new features currently in development are not related to claim status specifically, so we needed to update the base URL to reflect new capabilities.

  • (Which team do you work for, does your team own the maintenance of this component?)
    Travel Pay

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

N/A

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)
Travel Pay
MHV landing page (currently the only entry point to our application on staging)
Appointment app (currently behind a different feature flag)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/change-root-url/main December 11, 2024 19:17 Inactive
Copy link
Contributor

@IGallupSoCo IGallupSoCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to master/liz/change-root-url/main December 12, 2024 21:37 Inactive
@liztownd liztownd marked this pull request as ready for review December 13, 2024 13:31
@liztownd liztownd requested review from a team as code owners December 13, 2024 13:31
Copy link
Contributor

@ryanshaw ryanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VAOS files look good

Copy link
Contributor

@kjduensing kjduensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐸

Copy link
Contributor

@dcloud dcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to src/applications/mhv-landing-page/utilities/data/index.js looks good!

@liztownd liztownd merged commit de0659b into main Dec 16, 2024
76 of 79 checks passed
@liztownd liztownd deleted the liz/change-root-url branch December 16, 2024 13:25
Khoa-V-Nguyen pushed a commit that referenced this pull request Dec 16, 2024
* change root URL to travel-pay

* update breadcrumbs and claim details page

* update tests

* update routes and links

* add test for index redirect

* update link on MHV landing page

* update link in appt app (+ test)

* skip all travel pay cypress tests
@liztownd liztownd mentioned this pull request Dec 17, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants