-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travel Pay/change root url #33498
Travel Pay/change root url #33498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VAOS files look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to src/applications/mhv-landing-page/utilities/data/index.js
looks good!
* change root URL to travel-pay * update breadcrumbs and claim details page * update tests * update routes and links * add test for index redirect * update link on MHV landing page * update link in appt app (+ test) * skip all travel pay cypress tests
Are you removing, renaming or moving a folder in this PR?
If the folder you changed contains a
manifest.json
, search for itsentryName
in the content-build registry.json (theentryName
there will match).If an entry for this folder exists in content-build and you are:
Deleting a folder:
N/A
Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).
NOTE:
manifest.json
androotUrl
for our application, so I will have acontent-build
PR to merge as well.content-build
PRPR #2385
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Changing the
rootUrl
for our application to allow for future features.Old URL:
my-health/travel-claim-status
New URL:
my-health/travel-pay
Also adding a sub-route
/claims
to consolidate all travel claim related pages. The root path (/
) will redirect (using React Router<Redirect>
component) within the mounted Travel Pay app.The application has not yet been publicly rolled out, so a server-side redirect is not necessary.
(What is the solution, why is this the solution)
The initial
rootUrl
for the application as a whole wastravel-claim-status
but new features currently in development are not related toclaim status
specifically, so we needed to update the base URL to reflect new capabilities.(Which team do you work for, does your team own the maintenance of this component?)
Travel Pay
Related issue(s)
Link to ticket created in va.gov-team repo
department-of-veterans-affairs/va.gov-team#98178(Team GH Issue)
department-of-veterans-affairs/va.gov-team#98336 (MHV team issue to update on their landing page)
Link to
content-build
PRPR #2385
Link to
vsp-platform-revproxy
PRPR #780
Testing done
Screenshots
N/A
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Travel Pay
MHV landing page (currently the only entry point to our application on staging)
Appointment app (currently behind a different feature flag)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?