Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT]-Mayuran/BOT-2295/safari svh drop down not loading issue #17150

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mayuran-deriv
Copy link
Contributor

@mayuran-deriv mayuran-deriv commented Oct 10, 2024

The issue is that the dropdown icon on the Blockly page doesn't work in Safari. To fix this, I'm replacing the SVG during rendering for both the dark and light themes, but only in Safari.

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 13, 2024 9:38pm

@mayuran-deriv mayuran-deriv changed the title fix: svg change color [BOT]-Mayuran/BOT-2295/safari svh drop down not loading issue Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17150](https://github.com/deriv-com/deriv-app/pull/17150)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-mayuran-deriv-mayuran-svg-blockly-insafari.binary.sx?qa_server=red.derivws.com&app_id=24254
    - **Original**: https://deriv-app-git-fork-mayuran-deriv-mayuran-svg-blockly-insafari.binary.sx
- **App ID**: `24254`

Copy link
Contributor

github-actions bot commented Oct 10, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-mayuran-deriv-mayuran-svg-blockly-insafari.binary.sx/

@coveralls
Copy link

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 11317724827

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 53.608%

Files with Coverage Reduction New Missed Lines %
packages/cashier/src/app-content.tsx 1 0.0%
packages/cashier/src/components/cashier-breadcrumb/cashier-breadcrumb.tsx 2 70.59%
Totals Coverage Status
Change from base Build 11272857189: 0.001%
Covered Lines: 34759
Relevant Lines: 60323

💛 - Coveralls

img?.setAttributeNS?.('http://www.w3.org/1999/xlink', 'xlink:href', newIconUrl);
});
}
}, 100);
Copy link
Contributor

@rupato-deriv rupato-deriv Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this setTimeout ? Also can we do this in the dbot.js file at the top level ?
Also instead of the forach loop can we make a custom function and call it in the individual file where it is needed🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rupato-deriv changes updated as u suggested,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants