-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOT]-Mayuran/BOT-2295/safari svh drop down not loading issue #17150
base: master
Are you sure you want to change the base?
[BOT]-Mayuran/BOT-2295/safari svh drop down not loading issue #17150
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-mayuran-deriv-mayuran-svg-blockly-insafari.binary.sx/ |
Pull Request Test Coverage Report for Build 11317724827Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
img?.setAttributeNS?.('http://www.w3.org/1999/xlink', 'xlink:href', newIconUrl); | ||
}); | ||
} | ||
}, 100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this setTimeout ? Also can we do this in the dbot.js
file at the top level ?
Also instead of the forach loop can we make a custom function and call it in the individual file where it is needed🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @rupato-deriv changes updated as u suggested,
The issue is that the dropdown icon on the Blockly page doesn't work in Safari. To fix this, I'm replacing the SVG during rendering for both the dark and light themes, but only in Safari.