Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT]-Mayuran/BOT-2295/safari svh drop down not loading issue #17150

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions packages/bot-skeleton/src/assets/images/arrow-down.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import { localize } from '@deriv/translations';
import { plusIconDark } from '../../images';
import { runIrreversibleEvents, runGroupedEvents, modifyContextMenu } from '../../../utils';
import {
runIrreversibleEvents,
runGroupedEvents,
modifyContextMenu,
replaceDropdownIconsForSafari,
} from '../../../utils';

Blockly.Blocks.lists_create_with = {
protected_statements: ['STACK'],
Expand Down Expand Up @@ -61,10 +66,10 @@ Blockly.Blocks.lists_create_with = {
});
},
onchange(event) {
replaceDropdownIconsForSafari(this, 'VARIABLE');
if (!this.workspace || Blockly.derivWorkspace.isFlyoutVisible || this.workspace.isDragging()) {
return;
}

if (event.type === Blockly.Events.BLOCK_DRAG && !event.isStart) {
// Only allow "text_statement" type blocks
const blocks_in_stack = this.getBlocksInStatement('STACK');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { localize } from '@deriv/translations';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.lists_getIndex = {
init() {
Expand Down Expand Up @@ -43,6 +43,10 @@ Blockly.Blocks.lists_getIndex = {
category: Blockly.Categories.List,
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'MODE');
replaceDropdownIconsForSafari(this, 'WHERE');
},
mutationToDom() {
const container = document.createElement('mutation');
const isStatement = !this.outputConnection;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { localize } from '@deriv/translations';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.lists_getSublist = {
init() {
Expand Down Expand Up @@ -41,6 +41,10 @@ Blockly.Blocks.lists_getSublist = {
category: Blockly.Categories.List,
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'WHERE1');
replaceDropdownIconsForSafari(this, 'WHERE2');
},
mutationToDom() {
const container = document.createElement('mutation');
const isAt1 = this.getInput('AT1').type === Blockly.INPUT_VALUE;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { localize } from '@deriv/translations';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.lists_indexOf = {
init() {
Expand Down Expand Up @@ -49,6 +49,9 @@ Blockly.Blocks.lists_indexOf = {
description: localize('This block gives you the position of an item in a given list.'),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'END');
},
getRequiredValueInputs() {
return {
VALUE: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { localize } from '@deriv/translations';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.lists_setIndex = {
init() {
Expand Down Expand Up @@ -42,6 +42,10 @@ Blockly.Blocks.lists_setIndex = {
category: Blockly.Categories.List,
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'MODE');
replaceDropdownIconsForSafari(this, 'WHERE');
},
mutationToDom() {
const container = document.createElement('mutation');
const isAt = this.getInput('AT').type === Blockly.INPUT_VALUE;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { localize } from '@deriv/translations';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.lists_sort = {
init() {
Expand Down Expand Up @@ -52,6 +52,10 @@ Blockly.Blocks.lists_sort = {
),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'TYPE');
replaceDropdownIconsForSafari(this, 'DIRECTION');
},
getRequiredValueInputs() {
return {
LIST: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { localize } from '@deriv/translations';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.lists_split = {
init() {
Expand Down Expand Up @@ -39,6 +39,9 @@ Blockly.Blocks.lists_split = {
category: Blockly.Categories.List,
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'MODE');
},
mutationToDom() {
const container = document.createElement('mutation');
container.setAttribute('mode', this.getFieldValue('MODE'));
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { localize } from '@deriv/translations';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.controls_flow_statements = {
init() {
Expand Down Expand Up @@ -41,6 +41,9 @@ Blockly.Blocks.controls_flow_statements = {
customContextMenu(menu) {
modifyContextMenu(menu);
},
onchange() {
replaceDropdownIconsForSafari(this, 'FLOW');
},
};

Blockly.JavaScript.javascriptGenerator.forBlock.controls_flow_statements = block => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { localize } from '@deriv/translations';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.controls_for = {
init() {
Expand Down Expand Up @@ -65,6 +65,9 @@ Blockly.Blocks.controls_for = {
),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'VAR');
},
getRequiredValueInputs() {
return {
FROM: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { localize } from '@deriv/translations';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.controls_forEach = {
init() {
Expand Down Expand Up @@ -47,6 +47,9 @@ Blockly.Blocks.controls_forEach = {
),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'VAR');
},
getRequiredValueInputs() {
return {
LIST: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { localize } from '@deriv/translations';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.controls_whileUntil = {
init() {
Expand Down Expand Up @@ -46,6 +46,9 @@ Blockly.Blocks.controls_whileUntil = {
description: localize('This block repeats instructions as long as a given condition is true.'),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'MODE');
},
getRequiredValueInputs() {
return {
BOOL: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localize } from '@deriv/translations';
import { config } from '../../../../constants/config';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.contract_check_result = {
init() {
Expand Down Expand Up @@ -32,6 +32,7 @@ Blockly.Blocks.contract_check_result = {
};
},
onchange(event) {
replaceDropdownIconsForSafari(this, 'CHECK_RESULT');
if (!this.workspace || Blockly.derivWorkspace.isFlyoutVisible || this.workspace.isDragging()) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localize } from '@deriv/translations';
import { config } from '../../../../constants/config';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.read_details = {
init() {
Expand Down Expand Up @@ -31,6 +31,9 @@ Blockly.Blocks.read_details = {
description: localize('This block gives you information about your last contract.'),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'DETAIL_INDEX');
},
customContextMenu(menu) {
modifyContextMenu(menu);
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localize } from '@deriv/translations';
import { config } from '../../../../constants/config';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.check_direction = {
init() {
Expand Down Expand Up @@ -33,6 +33,9 @@ Blockly.Blocks.check_direction = {
),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'CHECK_DIRECTION');
},
customContextMenu(menu) {
modifyContextMenu(menu);
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localize } from '@deriv/translations';
import { config } from '../../../../constants/config';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.get_ohlc = {
init() {
Expand Down Expand Up @@ -39,6 +39,9 @@ Blockly.Blocks.get_ohlc = {
description: localize('This block gives you a specific candle from within the selected time interval.'),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'CANDLEINTERVAL_LIST');
},
getRequiredValueInputs() {
return {
CANDLEINDEX: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localize } from '@deriv/translations';
import { config } from '../../../../constants/config';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.ohlc = {
init() {
Expand Down Expand Up @@ -33,6 +33,9 @@ Blockly.Blocks.ohlc = {
description: localize('This block gives you a list of candles within a selected time interval.'),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'CANDLEINTERVAL_LIST');
},
customContextMenu(menu) {
modifyContextMenu(menu);
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localize } from '@deriv/translations';
import { config } from '../../../../constants/config';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.ohlc_values = {
init() {
Expand Down Expand Up @@ -46,6 +46,10 @@ Blockly.Blocks.ohlc_values = {
),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'CANDLEINTERVAL_LIST');
replaceDropdownIconsForSafari(this, 'OHLCFIELD_LIST');
},
customContextMenu(menu) {
modifyContextMenu(menu);
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localize } from '@deriv/translations';
import { config } from '../../../../constants/config';
import { modifyContextMenu } from '../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../utils';

Blockly.Blocks.read_ohlc = {
init() {
Expand Down Expand Up @@ -47,6 +47,10 @@ Blockly.Blocks.read_ohlc = {
description: localize('This block gives you the specified candle value for a selected time interval.'),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'OHLCFIELD_LIST');
replaceDropdownIconsForSafari(this, 'CANDLEINTERVAL_LIST');
},
getRequiredValueInputs() {
return {
CANDLEINDEX: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localize } from '@deriv/translations';
import { config } from '../../../../../constants/config';
import { modifyContextMenu } from '../../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../../utils';

Blockly.Blocks.ohlc_values_in_list = {
init() {
Expand Down Expand Up @@ -38,6 +38,9 @@ Blockly.Blocks.ohlc_values_in_list = {
description: localize('This block gives you the selected candle value from a list of candles.'),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'OHLCFIELD_LIST');
},
getRequiredValueInputs() {
return {
OHLCLIST: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localize } from '@deriv/translations';
import { config } from '../../../../../constants/config';
import { modifyContextMenu } from '../../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../../utils';

Blockly.Blocks.read_ohlc_obj = {
init() {
Expand Down Expand Up @@ -38,6 +38,9 @@ Blockly.Blocks.read_ohlc_obj = {
description: localize('This block gives you the selected candle value.'),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'OHLCFIELD_LIST');
},
getRequiredValueInputs() {
return {
OHLCOBJ: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localize } from '@deriv/translations';
import { config } from '../../../../../constants/config';
import { modifyContextMenu } from '../../../../utils';
import { modifyContextMenu, replaceDropdownIconsForSafari } from '../../../../utils';

Blockly.Blocks.balance = {
init() {
Expand Down Expand Up @@ -43,6 +43,9 @@ Blockly.Blocks.balance = {
),
};
},
onchange() {
replaceDropdownIconsForSafari(this, 'BALANCE_TYPE');
},
customContextMenu(menu) {
modifyContextMenu(menu);
},
Expand Down
Loading
Loading