-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reusbale deployment template #74
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Didn't realise you could set up a template like this, having it set up in this way will definitely make our lives maintaining the scripts much easier, nicely done. Requested a few small changes and additions.
…analytical-services/dfeshiny into 17-Deployment-yaml-template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments on the article side.
I tried testing it on a dashboard by changing @main to @17-Deployment-yaml-template in the uses line of the dashboard's deploy script, but GitHub actions didn't understand the ref:
dfe-analytical-services/dfeshiny/.github/workflows/deploy-dashboard-template.yaml@17-Deployment-yaml-template
Any idea if there's a way we can reference this branch to give it a test run? Guess we can just test it properly once it's in main if it's awkward to reference it from this branch.
switch workflow to run on docker base image
…analytical-services/dfeshiny into 17-Deployment-yaml-template
@rmbielby the pipeline has successfully been implemented on the transition matrices dashboard using the branch "17-Deployment-yaml-template", the initial error was due to an error in the workflow path. Here is the link to the successful run: https://github.com/dfe-analytical-services/Transition-matrices-dashboard/actions/runs/12792764689/job/35663986628 Note: I have removed the configuration options for installing the unit and terra dependencies. These dependencies are now pre-installed in the Docker image used for the workflow. As a result, they will always be available during pipeline runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last small change that we could do with for if people trigger from uncompleted PRs.
Co-authored-by: Rich Bielby <[email protected]>
Brief overview of changes
Added reusable template to be sourced from other repos for dashboard deployment.
Issue ticket number/s and link
https://github.com.mcas.ms/dfe-analytical-services/dfeshiny/issues/72