Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reusbale deployment template #74

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

oadetayo
Copy link
Contributor

Brief overview of changes

Added reusable template to be sourced from other repos for dashboard deployment.

Issue ticket number/s and link

https://github.com.mcas.ms/dfe-analytical-services/dfeshiny/issues/72

@oadetayo oadetayo assigned rmbielby and unassigned rmbielby Dec 25, 2024
Copy link
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Didn't realise you could set up a template like this, having it set up in this way will definitely make our lives maintaining the scripts much easier, nicely done. Requested a few small changes and additions.

.github/workflows/dashboard_deploy_template.yaml Outdated Show resolved Hide resolved
.github/workflows/dashboard_deploy_template.yaml Outdated Show resolved Hide resolved
.github/workflows/dashboard_deploy_template.yaml Outdated Show resolved Hide resolved
.github/workflows/dashboard_deploy_template.yaml Outdated Show resolved Hide resolved
@oadetayo oadetayo requested a review from cjrace December 30, 2024 15:27
Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments on the article side.

I tried testing it on a dashboard by changing @main to @17-Deployment-yaml-template in the uses line of the dashboard's deploy script, but GitHub actions didn't understand the ref:

dfe-analytical-services/dfeshiny/.github/workflows/deploy-dashboard-template.yaml@17-Deployment-yaml-template

Any idea if there's a way we can reference this branch to give it a test run? Guess we can just test it properly once it's in main if it's awkward to reference it from this branch.

vignettes/using-the-dfeshiny-deploy-template.Rmd Outdated Show resolved Hide resolved
vignettes/using-the-dfeshiny-deploy-template.Rmd Outdated Show resolved Hide resolved
vignettes/using-the-dfeshiny-deploy-template.Rmd Outdated Show resolved Hide resolved
vignettes/using-the-dfeshiny-deploy-template.Rmd Outdated Show resolved Hide resolved
vignettes/using-the-dfeshiny-deploy-template.Rmd Dismissed Show dismissed Hide dismissed
vignettes/using-the-dfeshiny-deploy-template.Rmd Dismissed Show dismissed Hide dismissed
vignettes/using-the-dfeshiny-deploy-template.Rmd Dismissed Show dismissed Hide dismissed
vignettes/using-the-dfeshiny-deploy-template.Rmd Dismissed Show dismissed Hide dismissed
vignettes/using-the-dfeshiny-deploy-template.Rmd Dismissed Show dismissed Hide dismissed
vignettes/using-the-dfeshiny-deploy-template.Rmd Dismissed Show dismissed Hide dismissed
@oadetayo oadetayo requested a review from rmbielby January 2, 2025 14:06
@cjrace cjrace added this to the v1.0 milestone Jan 2, 2025
@oadetayo
Copy link
Contributor Author

oadetayo commented Jan 15, 2025

Few small comments on the article side.

I tried testing it on a dashboard by changing @main to @17-Deployment-yaml-template in the uses line of the dashboard's deploy script, but GitHub actions didn't understand the ref:

dfe-analytical-services/dfeshiny/.github/workflows/deploy-dashboard-template.yaml@17-Deployment-yaml-template

Any idea if there's a way we can reference this branch to give it a test run? Guess we can just test it properly once it's in main if it's awkward to reference it from this branch.

Few small comments on the article side.

I tried testing it on a dashboard by changing @main to @17-Deployment-yaml-template in the uses line of the dashboard's deploy script, but GitHub actions didn't understand the ref:

dfe-analytical-services/dfeshiny/.github/workflows/deploy-dashboard-template.yaml@17-Deployment-yaml-template

Any idea if there's a way we can reference this branch to give it a test run? Guess we can just test it properly once it's in main if it's awkward to reference it from this branch.

@rmbielby the pipeline has successfully been implemented on the transition matrices dashboard using the branch "17-Deployment-yaml-template", the initial error was due to an error in the workflow path. Here is the link to the successful run: https://github.com/dfe-analytical-services/Transition-matrices-dashboard/actions/runs/12792764689/job/35663986628

Note: I have removed the configuration options for installing the unit and terra dependencies. These dependencies are now pre-installed in the Docker image used for the workflow. As a result, they will always be available during pipeline runtime.

Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last small change that we could do with for if people trigger from uncompleted PRs.

@oadetayo oadetayo requested a review from rmbielby January 20, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants