Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra accessibility string from a11y_panel #83

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

rmbielby
Copy link
Contributor

@rmbielby rmbielby commented Jan 2, 2025

Brief overview of changes

I'd created an unnecessary extra div and title string for the a11y_panel and this PR just removes that.

Why are these changes being made?

Improve the layout of the a11y_panel

Detailed description of changes

  • Removed extra div()
  • Removed "Accessibility"
  • Updated tests to reflect the simpler structure

Additional information for reviewers

...

Issue ticket number/s and link

...

R/bookmark.R Fixed Show fixed Hide fixed
R/bookmark.R Fixed Show fixed Hide fixed
R/bookmark.R Fixed Show fixed Hide fixed
R/bookmark.R Fixed Show fixed Hide fixed
R/bookmark.R Fixed Show fixed Hide fixed
R/bookmark.R Fixed Show fixed Hide fixed
R/bookmark.R Fixed Show fixed Hide fixed
Copy link
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we'll need to update the LAIT dashboard too after this is in?

@rmbielby rmbielby merged commit 2de5915 into main Jan 2, 2025
10 checks passed
@rmbielby rmbielby deleted the bugfix/accessibility-page-title branch January 2, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants