Add centralised link list in the network management

[MizukiTemma]

Short description

This is an updated version of #2898 with improvement sugeestion by @david-venhoff (Thank you 🙏)

Proposed changes

• Reuse the template and view of region link list
• Do not prefetch links in the centalized link list
• Use the util function replace_links if users replace an URL per ✏️ in a row of the centalized link list (because we are not prefetching)*1

Side effects

• *1 is sadly slow (but this is actually what you get when you use "Search&Replace" on the upper right corner). We can alternatively deactivate link replacement in "option" column until further performance improvement

Resolved issues

Fixes: #1443

---

Pull Request Review Guidelines

[codeclimate]

Code Climate has analyzed commit bb28096 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 30.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.7% (0.0% change).

View more on Code Climate.

[deen13]

I've tested the feature, and it works fine on my local machine. However, I am concerned about the use of time.sleep calls. In my experience, this is not a reliable practice.

The issue is that the action we're waiting for with time.sleep can vary in execution time depending on factors like system load, potentially causing failures in production where debugging would be challenging. Additionally, if the underlying action runs within milliseconds, time.sleep adds unnecessary wait time, causing the user to wait while the system idles.

Is there another way to wait for the signal to finish?

[MizukiTemma]

I've tested the feature, and it works fine on my local machine. However, I am concerned about the use of time.sleep calls. In my experience, this is not a reliable practice.

The issue is that the action we're waiting for with time.sleep can vary in execution time depending on factors like system load, potentially causing failures in production where debugging would be challenging. Additionally, if the underlying action runs within milliseconds, time.sleep adds unnecessary wait time, causing the user to wait while the system idles.

Is there another way to wait for the signal to finish?

Totally agree 👀 but me neither know any handy way.
I'd suggest to solve this problem (or general performance improvement of link checker) in another issue 🤔

[david-venhoff]

Thanks! this looks mostly good to me.

An additional column for showing the region(s) of the link could be useful, but we can also open another issue for that I guess.

[MizukiTemma]

@david-venhoff @deen13
Thank you for your review and suggestions 😸
Now I'd like to wait for #3003 to see how it impacts the performance.

[david-venhoff]

Awesome, this looks pretty much good to me 🎉

It might be helpful to add a new table column to the network management link list that shows the regions of the link, but maybe that should better be done in a separate pr, as it might be a bit of effort.

I think it would be useful to add some tests for e.g. the bulk actions and the search and replace functionality in network management. But that could of course be done in a separate pr.

[MizukiTemma]

It might be helpful to add a new table column to the network management link list that shows the regions of the link, but maybe that should better be done in a separate pr, as it might be a bit of effort.

I think it would be useful to add some tests for e.g. the bulk actions and the search and replace functionality in network management. But that could of course be done in a separate pr.

Agree 👍 Opned issues #3061 and #3062

[david-venhoff]

This pr looks good to go to me 🎉

I noticed that we still perform a lot of database queries in the linkcheck view, but since the performance is acceptable right now I think we can keep it that way for now. I pushed a commit to this branch that got rid of the lowest hanging fruits though 😃

Not working on integreat anymore

[PeterNerlich]

Did you accidentally remove model changes during squashing? Did I miss something? I get `'Url' object has no attribute 'region_links' when I try to change links

[MizukiTemma]

@PeterNerlich Thank you for the review 😸 Yes, it seems I messed up while rebasing and/or squashing 😅 It should work again

[PeterNerlich]

It appears to work now, though on closer inspection rewriting links doesn't always yield the expected results (e.g. rewriting the willkommen link with its 3 usages, replacing it to link to …/wullkommen and expecting it to appear in Invalid, also with 3 usages – instead it disappeared on me altogether) but this might just be a problem with the linkcheck library and not this PR.

Also, FYI, I saw a few errors like django.db.utils.IntegrityError: insert or update on table "linkcheck_link" violates foreign key constraint "linkcheck_link_url_id_c5f791e9_fk" followed by DETAIL: Key (url_id)=(34) is not present in table "linkcheck_url". on the console, but they as well are from within the linkcheck code and probably not caused by anything in this PR (rather, I suspect my local db state was at fault).

I hope this is the case, so I'll approve. The other comments are ideas non-essential to this PR as well.