Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spaces Key API #958

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

lee-aaron
Copy link

OBJECT-6022

This adds information about the Spaces Key API to the OpenAPI spec.

I can add a [Beta] tag somewhere if needed as users would need to be on the flipper to access this!

@lee-aaron lee-aaron force-pushed the alee/keys-api branch 2 times, most recently from 2749a98 to 926ae10 Compare January 6, 2025 20:07
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I did leave a few comments in-line. Let me know if you have any questions about them.

specification/resources/spaces/key_create.yml Outdated Show resolved Hide resolved
specification/resources/spaces/models/grant.yml Outdated Show resolved Hide resolved
specification/resources/spaces/key_list.yml Show resolved Hide resolved
specification/resources/spaces/models/key_response.yml Outdated Show resolved Hide resolved
specification/resources/spaces/parameters.yml Outdated Show resolved Hide resolved
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌 A couple tiny changes needed for the update response bodies.

specification/resources/spaces/responses/key_update.yml Outdated Show resolved Hide resolved
specification/resources/spaces/responses/key_create.yml Outdated Show resolved Hide resolved
Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants