Miscellaneous Internal Changes #499

lishaduck · 2024-11-27T02:07:50Z

My attempt at #497. :)

I spent a few hours figuring out ssh auth,¹ so you beat me to the push.
However, I caught a few other things, so I'm pushing anyway, ~~and will clean it up in a minute~~.

I decided to try jj out today. It's nice, but doesn't support https auth. ↩

netlify · 2024-11-27T02:07:54Z

👷 Deploy request for elm-pages-todos pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`7c832d1`

lishaduck · 2024-11-27T02:30:56Z

Hey, look at that! I force pushed :)
I feel really silly relearning a vcs, but it's a fun break from normalcy for thanksgiving

lishaduck

Aaaaaaaand I found some more random stuff while perusing, but I'm awaiting an npm install to verify some stuff.

lishaduck · 2024-11-27T02:38:36Z

generator/tsconfig.json

@@ -4,9 +4,10 @@
    "moduleResolution": "node",
    "checkJs": true,
    "allowJs": true,
+    "noEmit": true,


Otherwise, I get an error about it can't output .js files because they're already authored in js.

lishaduck · 2024-11-27T02:39:55Z

generator/tsconfig.json

    "strict": true,
    "resolveJsonModule": true,
-    "lib": ["es2015", "es2017.object", "esnext", "dom"]
+    "lib": ["esnext", "dom"]


I was getting an error about bad targets & stuff, and this seemed to resolve it. The es* libs implicitly include all the previous versions.

lishaduck · 2024-11-27T02:40:17Z

package.json

@@ -4,7 +4,7 @@
  "version": "3.0.17",
  "homepage": "https://elm-pages.com",
  "moduleResolution": "node",
-  "description": "Type-safe static sites, written in pure elm with your own custom elm-markup syntax.",
+  "description": "Hybrid Elm framework with full-stack and static routes.",


Just took it from the repo description.

lishaduck · 2024-11-27T02:52:46Z

generator/tsconfig.json

    "strict": true,
-    "resolveJsonModule": true,


It didn't look like this was needed anymore, and latest ts5.7 makes backcompat a pain, so I removed it.

lishaduck · 2024-11-27T02:53:05Z

generator/tsconfig.json

@@ -1,12 +1,13 @@
 {
  "compilerOptions": {
    "types": ["node"],
-    "moduleResolution": "node",
+    "module": "NodeNext",


The node value is deprecated.

lishaduck · 2024-11-27T02:53:59Z

generator/src/codegen-template-builder.js

I ⌘+F'd it and didn't see any references to this, so I took it to be unused.

lishaduck · 2024-11-27T02:54:17Z

package.json

@@ -3,7 +3,6 @@
  "type": "module",
  "version": "3.0.17",
  "homepage": "https://elm-pages.com",
-  "moduleResolution": "node",


This isn't a thing.

lishaduck · 2024-11-27T02:56:28Z

package.json

    "@types/make-fetch-happen": "^10.0.4",
    "@types/micromatch": "^4.0.9",
    "@types/node": "^22.10.0",
    "@types/serve-static": "^1.15.7",
+    "@types/which": "~3.0.4",


TS was complaining about the lack of types for which, so I ran typesync.
Note that it uses a tilde, as DefinitelyTyped keeps majors and minors in sync with the upstream. Now, there aren't super recent types for which, so it's a bit pointless, but it just did it automatically.

lishaduck

~~Last batch :)~~

lishaduck · 2024-11-27T03:46:21Z

generator/tsconfig.json

@@ -1,12 +1,12 @@
 {
  "compilerOptions": {
-    "types": ["node"],


This prevented @types packages from working.

lishaduck · 2024-11-27T03:46:38Z

generator/src/hello.ts

I assume this is unused?

The tsconfig overrides it.

lishaduck · 2024-11-28T18:19:51Z

jsconfig.json

If you've got both, most things won't work right.

lishaduck · 2024-11-28T18:19:57Z

tsconfig.json

@@ -3,6 +3,7 @@
    "strict": true,
    "target": "ESNext",
    "module": "NodeNext",
-    "moduleResolution": "NodeNext"
+    "moduleResolution": "NodeNext",
+    "checkJs": true


I assumed that you want ts checking of js files, given the jsconfig.

lishaduck · 2024-12-01T19:35:33Z

@dillonkearns, ping :)

miniBill · 2024-12-05T01:05:55Z

Could you minimize the diff? There is some formatting noise.
In general these all seem reasonable, but I haven't inspected them deeply.

lishaduck · 2024-12-05T01:55:26Z

Could you minimize the diff? There is some formatting noise.

I could, but the repo has a prettier config, so I assumed it was oversight. GitHub only highlights non-whitespace changes, so all of the spots that got actual changes are both distinct and separate (the formatting didn't wasn't in the seconds I was editing).
I'm happy to revert it, just wanted to explain my rationale for not doing so.

lishaduck · 2024-12-05T02:08:04Z

Oh, I don't have enough context to be sure, but it looks like request-cache-fs.js unused, and if it's deleted, you can also remove the memfs dependency.

Maybe I'll knip and report back.

EDIT: Here's results (I removed the most obvious false-positives):

Unused Summary

Unused files (82)
examples/**
generator/src/render-test.js
generator/src/render-worker.js
generator/src/request-cache-fs.js
generator/static-code/elm-pages.js
generator/static-code/hmr.js
generator/template/custom-backend-task.ts
generator/template/elm-pages.config.mjs
generator/template/index.ts
generator/template/script/.elm-pages/compiled-ports/custom-backend-task.mjs
generator/template/script/custom-backend-task.ts
Unused dependencies (1)
jsesc  package.json
Unused devDependencies (5)
@types/jsesc          package.json
elm-test              package.json
Unlisted binaries (2)
elm-pages  .github/workflows/ci.yml
elm-pages  package.json
Unresolved imports (1)
../generator/src/generate-records.js  tests/generated-files.test.js:3:33
Unused exports (24)
elmOptimizeLevel2       build           function  generator/src/build.js:453:17                
writeFileSyncSafe       fs              function  generator/src/dir-helpers.js:38:17           
copyDirFlat             fs              function  generator/src/dir-helpers.js:47:23           
copyDirNested           fs              function  generator/src/dir-helpers.js:61:23           
restoreColor                            unknown   generator/src/error-formatter.js:84:14       
replaceTemplate         preRenderHtml   function  generator/src/pre-render-html.js:71:17       
pipeShells              renderer        function  generator/src/render.js:1016:17              
question                renderer        function  generator/src/render.js:1101:23              
render                  renderer        function  generator/src/render.js:45:23                
shell                   renderer        function  generator/src/render.js:951:17               
routeVariantDefinition  routeHelpers    function  generator/src/route-codegen-helpers.js:126:17
joinPath                routeHelpers    function  generator/src/route-codegen-helpers.js:202:17
parseRouteParams        routeHelpers    function  generator/src/route-codegen-helpers.js:20:17 
newHelper               routeHelpers    function  generator/src/route-codegen-helpers.js:214:17
toElmPathPattern        routeHelpers    function  generator/src/route-codegen-helpers.js:241:17
camelToKebab            routeHelpers    function  generator/src/route-codegen-helpers.js:300:17
paramsRecord            routeHelpers    function  generator/src/route-codegen-helpers.js:307:17
routeVariant            routeHelpers    function  generator/src/route-codegen-helpers.js:329:17
destructureRoute        routeHelpers    function  generator/src/route-codegen-helpers.js:337:17
referenceRouteParams    routeHelpers    function  generator/src/route-codegen-helpers.js:343:17
emptyRouteParams        routeHelpers    function  generator/src/route-codegen-helpers.js:349:17
toFieldName             routeHelpers    function  generator/src/route-codegen-helpers.js:356:17
routeParams             routeHelpers    function  generator/src/route-codegen-helpers.js:4:17  
isReadableStream        validateStream  function  generator/src/validate-stream.js:3:17

miniBill · 2024-12-05T11:19:42Z

Could you minimize the diff? There is some formatting noise.

I could, but the repo has a prettier config, so I assumed it was oversight. GitHub only highlights non-whitespace changes, so all of the spots that got actual changes are both distinct and separate (the formatting didn't wasn't in the seconds I was editing). I'm happy to revert it, just wanted to explain my rationale for not doing so.

Makes sense! As an option, you could create a separate "format everything" PR and base this one on that one?

@dillonkearns how do you feel about the idea?

lishaduck · 2024-12-05T14:16:04Z

Makes sense! As an option, you could create a separate "format everything" PR and base this one on that one?

@dillonkearns how do you feel about the idea?

Or the other way around, you can't make stacked PRs from forks so there'd still be the diff. I'd be happy to do that if @dillonkearns approves.

dillonkearns · 2024-12-28T23:26:49Z

Yes, I'd be very happy to accept a formatting PR!

In general, I'm finding it hard to review this PR because there is a lot going on, and in particular a lot of things which I have trouble verifying.

If it's something that has a unit test and I can see it passing, then I can confidently review and merge. There are some things in here which won't really have an impact on user-facing things, so they're more low-risk. But there is a lot going on that is hard to separate out. If you're up for it, I would find it a lot easier to split this up into a few smaller PRs that target related areas. Ideally, it would be nice if I could review some PRs where it's very clear there is no risk or low risk for user-facing issues and separate that out from things that need more careful verification.

Happy to discuss that strategy ore if you would like!

lishaduck · 2024-12-28T23:50:16Z

Happy to discuss that strategy ore if you would like!

I guess a treewide format would be one, updating typescript stuff would be another (fixes to types, tsconfig settings, and @types packages, in separate commits?), deleting dead code is another, and updating the package description would be the other one.

Do those four sound good, or would you prefer if I also split up the ts ones as well?

dillonkearns · 2024-12-28T23:52:08Z

That sounds excellent, yes! That would be a lot easier for me to go through quickly and separate out what is low risk 👍

lishaduck changed the title ~~Vite6~~ Misc Changes Nov 27, 2024

lishaduck force-pushed the vite6 branch from 749982c to a0410de Compare November 27, 2024 02:29

chore: update npm description

8256ac2

lishaduck force-pushed the vite6 branch from a0410de to a73c379 Compare November 27, 2024 02:33

lishaduck commented Nov 27, 2024

View reviewed changes

lishaduck added 2 commits November 26, 2024 20:48

fix: tsconfig

506d9c5

chore: remove random file

492205b

lishaduck force-pushed the vite6 branch from a73c379 to b26965c Compare November 27, 2024 02:51

lishaduck commented Nov 27, 2024

View reviewed changes

lishaduck added 3 commits November 26, 2024 21:44

chore: run typesync to get types for which

49de008

fix: allow @types to propgate

77774af

chore: delete another random file

bda7b97

lishaduck force-pushed the vite6 branch from b26965c to bda7b97 Compare November 27, 2024 03:45

lishaduck commented Nov 27, 2024

View reviewed changes

lishaduck added 2 commits November 28, 2024 12:09

chore: remove jsconfig

80ecb26

The tsconfig overrides it.

chore: add some types

7c832d1

lishaduck force-pushed the vite6 branch from 39847c5 to 7c832d1 Compare November 28, 2024 18:10

lishaduck commented Nov 28, 2024

View reviewed changes

lishaduck changed the title ~~Misc Changes~~ Miscellaneous Internal Changes Nov 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Miscellaneous Internal Changes #499

Miscellaneous Internal Changes #499

lishaduck commented Nov 27, 2024 •

edited

Loading

netlify bot commented Nov 27, 2024 •

edited

Loading

lishaduck commented Nov 27, 2024

lishaduck left a comment

lishaduck Nov 27, 2024

lishaduck Nov 27, 2024

lishaduck Nov 27, 2024

lishaduck Nov 27, 2024

lishaduck Nov 27, 2024

lishaduck Nov 27, 2024

lishaduck Nov 27, 2024

lishaduck Nov 27, 2024

lishaduck left a comment •

edited

Loading

lishaduck Nov 27, 2024 •

edited

Loading

lishaduck Nov 27, 2024

lishaduck Nov 28, 2024

lishaduck Nov 28, 2024

lishaduck commented Dec 1, 2024

miniBill commented Dec 5, 2024

lishaduck commented Dec 5, 2024

lishaduck commented Dec 5, 2024 •

edited

Loading

miniBill commented Dec 5, 2024

lishaduck commented Dec 5, 2024

dillonkearns commented Dec 28, 2024

lishaduck commented Dec 28, 2024 •

edited

Loading

dillonkearns commented Dec 28, 2024

Miscellaneous Internal Changes #499

Are you sure you want to change the base?

Miscellaneous Internal Changes #499

Conversation

lishaduck commented Nov 27, 2024 • edited Loading

Footnotes

netlify bot commented Nov 27, 2024 • edited Loading

👷 Deploy request for elm-pages-todos pending review.

lishaduck commented Nov 27, 2024

lishaduck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lishaduck left a comment • edited Loading

Choose a reason for hiding this comment

lishaduck Nov 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lishaduck commented Dec 1, 2024

miniBill commented Dec 5, 2024

lishaduck commented Dec 5, 2024

lishaduck commented Dec 5, 2024 • edited Loading

miniBill commented Dec 5, 2024

lishaduck commented Dec 5, 2024

dillonkearns commented Dec 28, 2024

lishaduck commented Dec 28, 2024 • edited Loading

dillonkearns commented Dec 28, 2024

lishaduck commented Nov 27, 2024 •

edited

Loading

netlify bot commented Nov 27, 2024 •

edited

Loading

lishaduck left a comment •

edited

Loading

lishaduck Nov 27, 2024 •

edited

Loading

lishaduck commented Dec 5, 2024 •

edited

Loading

lishaduck commented Dec 28, 2024 •

edited

Loading