Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Internal Changes #499

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+100 −37
Open

Miscellaneous Internal Changes #499

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8256ac2
chore: update npm description
lishaduck Nov 26, 2024
506d9c5
fix: tsconfig
lishaduck Nov 26, 2024
492205b
chore: remove random file
lishaduck Nov 26, 2024
49de008
chore: run typesync to get types for which
lishaduck Nov 26, 2024
77774af
fix: allow @types to propgate
lishaduck Nov 26, 2024
bda7b97
chore: delete another random file
lishaduck Nov 26, 2024
80ecb26
chore: remove jsconfig
lishaduck Nov 27, 2024
7c832d1
chore: add some types
lishaduck Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file removed generator/src/codegen-template-builder.js
View file
Open in desktop
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ⌘+F'd it and didn't see any references to this, so I took it to be unused.

Empty file.
5 changes: 0 additions & 5 deletions generator/src/hello.ts
View file
Open in desktop
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is unused?

This file was deleted.

8 changes: 4 additions & 4 deletions generator/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"compilerOptions": {
"types": ["node"],
Copy link
Author

@lishaduck lishaduck Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevented @types packages from working.

"moduleResolution": "node",
"module": "NodeNext",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node value is deprecated.

"isolatedModules": true,
"checkJs": true,
"allowJs": true,
"noEmit": true,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, I get an error about it can't output .js files because they're already authored in js.

"strict": true,
"resolveJsonModule": true,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't look like this was needed anymore, and latest ts5.7 makes backcompat a pain, so I removed it.

"lib": ["es2015", "es2017.object", "esnext", "dom"]
"lib": ["esnext", "dom"]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting an error about bad targets & stuff, and this seemed to resolve it. The es* libs implicitly include all the previous versions.

},
"exclude": ["node_modules", "generated"]
}
44 changes: 44 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"type": "module",
"version": "3.0.17",
"homepage": "https://elm-pages.com",
"moduleResolution": "node",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a thing.

"description": "Type-safe static sites, written in pure elm with your own custom elm-markup syntax.",
"description": "Hybrid Elm framework with full-stack and static routes.",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took it from the repo description.

"main": "index.js",
"scripts": {
"start": "cd examples/end-to-end && npm i && npx elm-pages dev",
Expand Down Expand Up @@ -50,12 +49,17 @@
"which": "^5.0.0"
},
"devDependencies": {
"@types/busboy": "~1.5.4",
"@types/connect": "~3.4.38",
"@types/cookie-signature": "~1.1.2",
"@types/cross-spawn": "^6.0.6",
"@types/fs-extra": "^11.0.4",
"@types/jsesc": "~3.0.3",
"@types/make-fetch-happen": "^10.0.4",
"@types/micromatch": "^4.0.9",
"@types/node": "^22.10.0",
"@types/serve-static": "^1.15.7",
"@types/which": "~3.0.4",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS was complaining about the lack of types for which, so I ran typesync.
Note that it uses a tilde, as DefinitelyTyped keeps majors and minors in sync with the upstream. Now, there aren't super recent types for which, so it's a bit pointless, but it just did it automatically.

"cypress": "^13.16.0",
"elm-codegen": "^0.6.1",
"elm-optimize-level-2": "^0.3.5",
Expand Down
Loading