Collapse union types #370
Merged
Collapse union types #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Oct 10, 2024
go/vt/sqlparser/ast.go
Outdated
| @@ -547,7 +556,7 @@ func (q QueryOpts) Format(buf *TrackedBuffer) { | |||
| // Select represents a SELECT statement. | |||
| type Select struct { | |||
| Comments Comments | |||
| QueryOpts QueryOpts | |||
| QueryOpts *QueryOpts | |||
There was a problem hiding this comment.
I would avoid changing things to pointers or vice versa if possible, there are so many places we inspect the AST where expect a nil / zero value for a sub field etc. If it's required for perf that's fine, but be very careful and check all refs to them.
There was a problem hiding this comment.
Restored previous pointer/merge behavior.
|
Locally testing bumps with GMS/Dolt look clean. Going to merge. |
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace union type with one interface type. Static type access in reducer stack become runt-time interface conversions. The compiler builder loses the ability to do type checking at build time, so type safety has to be checked with testing.
Additional type enforcements are needed for nil-safety. Nil return values have to be typed correctly in the interface variable for casts up the stack to pass. Interface types do not have default nil values, so I've added
tryCastXXXhelper functions to accommodate untyped nils.