Include validation analyzer #7071

fkpwolf · 2021-02-20T07:15:13Z

Microsoft Reviewers: Open in CodeFlow

codecov · 2021-02-25T08:17:32Z

Codecov Report

Merging #7071 (965c26c) into v3 (1af6c2e) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v3    #7071      +/-   ##
==========================================
- Coverage   84.12%   84.08%   -0.04%     
==========================================
  Files         373      373              
  Lines       14535    14538       +3     
  Branches     2764     2764              
==========================================
- Hits        12227    12225       -2     
- Misses       1737     1742       +5     
  Partials      571      571

Impacted Files	Coverage Δ
src/docfx/Errors.cs	`88.42% <100.00%> (+0.39%)`	⬆️
.../docfx/lib/moniker/EvaluatorWithMonikersVisitor.cs	`88.23% <100.00%> (-0.34%)`	⬇️
src/docfx/lib/moniker/ExpressionCreator.cs	`97.10% <100.00%> (ø)`
src/docfx/lib/moniker/MonikerRangeParser.cs	`100.00% <100.00%> (ø)`
src/docfx/lib/git/GitUtility.cs	`55.85% <0.00%> (-4.51%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af6c2e...965c26c. Read the comment docs.

fkpwolf · 2021-02-26T09:30:37Z

updated to latest version. Now fix of Errors not included. Wait to see if it will make build failed.

.editorconfig

docs/specs/markdown.yml

yufeih · 2021-03-02T01:51:53Z

src/docfx/Errors.cs

            /// </summary>
            /// Behavior: ✔️ Message: ❌
-            public static Error MonikerRangeInvalid(SourceInfo? operand, FormattableString message)
-                => new Error(ErrorLevel.Error, "moniker-range-invalid", message, operand);
+            public static Error MonikerRangeMissing(SourceInfo<string?> operand, string moniker)


@928PJY to see if this one needs to be expanded to multiple error codes. I am tentative to do this change. This error is like regular expression parse error, we could have a single exception type, with exception details as args, like this:

Suggested change

public static Error MonikerRangeMissing(SourceInfo<string?> operand, string moniker)

public static Error MonikerRangeInvalid(SourceInfo source, string message)

ghost · 2021-03-02T09:14:03Z

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

ghost · 2021-03-02T09:31:49Z

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

ghost · 2021-03-04T04:58:56Z

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

ghost · 2021-03-04T05:19:46Z

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

fkpwolf · 2021-03-04T06:37:52Z

/zap

fkpwolf · 2021-03-04T06:38:26Z

/azp run

azure-pipelines · 2021-03-04T06:38:39Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2021-03-04T07:13:29Z

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

ghost · 2021-03-04T07:15:48Z

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

* Update Errors.cs * include analyzer package * update version * upgrade version * Minor clean up * update version * merge * update version * restore analyzer severity level * fix analyzer error of Errors.cs * fix test case * fix test case * change "disallowed-html" to "disallowed-html-tag" * change version * update version * test warn as error * fix Errors.cs * update version Co-authored-by: Yufei Huang <[email protected]>

fkpwolf added 14 commits November 19, 2020 15:46

Update Errors.cs

b562661

Merge branch 'v3' of https://github.com/fkpwolf/docfx into v3

8dcc376

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

27b6751

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

48cc6e2

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

07d9ca5

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

4300c3a

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

e8dba76

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

a3e3543

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

de30066

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

56cf0c8

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

7767755

include analyzer package

a76814c

update version

7668c67

upgrade version

375acfc

yufeih and others added 3 commits February 26, 2021 17:13

Minor clean up

84447d7

update version

4b740aa

merge

77b1f25

fkpwolf requested a review from yufeih February 26, 2021 09:27

fkpwolf marked this pull request as ready for review February 26, 2021 09:28

fkpwolf added 3 commits February 26, 2021 17:31

Merge branch 'v3' into include-validation-analyzer

378e9f2

merge

4499cbd

update version

a63ebde

yufeih force-pushed the v3 branch from 84447d7 to 1b50cbe Compare February 26, 2021 09:57

fkpwolf added 3 commits February 26, 2021 17:58

Merge branch 'v3' of https://github.com/fkpwolf/docfx into v3

fa63c8c

merge

9e94265

Merge branch 'v3' into include-validation-analyzer

0feabc2

fkpwolf changed the title ~~Include validation analyzer~~ Include validation analyzer[not merge] Feb 26, 2021

restore analyzer severity level

b964b14

fkpwolf requested a review from xichan-ms March 1, 2021 02:18

fix test case

55fd248

fkpwolf requested a review from OsmondJiang March 1, 2021 04:44

fix test case

6a76820

yufeih reviewed Mar 2, 2021

View reviewed changes

change "disallowed-html" to "disallowed-html-tag"

cd580a8

AngryBerryMS added the v3 label Mar 2, 2021

change version

2ae44a6

update version

2907feb

test warn as error

ea10204

fkpwolf requested a review from live1206 March 3, 2021 09:14

yufeih mentioned this pull request Mar 4, 2021

warnAsError in CI #7123

Merged

fkpwolf added 2 commits March 4, 2021 12:55

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

c4feb97

Merge branch 'v3' into include-validation-analyzer

cb05d86

fix Errors.cs

efae682

fkpwolf added 3 commits March 4, 2021 15:10

update version

b584359

Merge branch 'v3' of https://github.com/dotnet/docfx into v3

0b69a4d

Merge branch 'v3' into include-validation-analyzer

965c26c

OsmondJiang approved these changes Mar 4, 2021

View reviewed changes

ghost merged commit 9c36a70 into dotnet:v3 Mar 4, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include validation analyzer #7071

Include validation analyzer #7071

fkpwolf commented Feb 20, 2021 •

edited by ghost

Loading

codecov bot commented Feb 25, 2021 •

edited

Loading

fkpwolf commented Feb 26, 2021

yufeih Mar 2, 2021

ghost commented Mar 2, 2021

From the bot dev team

ghost commented Mar 2, 2021

From the bot dev team

ghost commented Mar 4, 2021

From the bot dev team

ghost commented Mar 4, 2021

From the bot dev team

fkpwolf commented Mar 4, 2021

fkpwolf commented Mar 4, 2021

azure-pipelines bot commented Mar 4, 2021

ghost commented Mar 4, 2021

From the bot dev team

ghost commented Mar 4, 2021

From the bot dev team

	public static Error MonikerRangeMissing(SourceInfo<string?> operand, string moniker)
	public static Error MonikerRangeInvalid(SourceInfo source, string message)

Include validation analyzer #7071

Include validation analyzer #7071

Conversation

fkpwolf commented Feb 20, 2021 • edited by ghost Loading

Microsoft Reviewers: Open in CodeFlow

codecov bot commented Feb 25, 2021 • edited Loading

Codecov Report

fkpwolf commented Feb 26, 2021

yufeih Mar 2, 2021

Choose a reason for hiding this comment

ghost commented Mar 2, 2021

From the bot dev team

ghost commented Mar 2, 2021

From the bot dev team

ghost commented Mar 4, 2021

From the bot dev team

ghost commented Mar 4, 2021

From the bot dev team

fkpwolf commented Mar 4, 2021

fkpwolf commented Mar 4, 2021

azure-pipelines bot commented Mar 4, 2021

ghost commented Mar 4, 2021

From the bot dev team

ghost commented Mar 4, 2021

From the bot dev team

fkpwolf commented Feb 20, 2021 •

edited by ghost

Loading

codecov bot commented Feb 25, 2021 •

edited

Loading