Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnAsError in CI #7123

Merged
merged 2 commits into from
Mar 4, 2021
Merged

warnAsError in CI #7123

merged 2 commits into from
Mar 4, 2021

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Mar 4, 2021

So warnings break CI.

Related #7071 dotnet/roslyn#43051

Microsoft Reviewers: Open in CodeFlow

@yufeih yufeih added the v3 label Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #7123 (8a30804) into v3 (fe66886) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3    #7123      +/-   ##
==========================================
- Coverage   84.11%   84.08%   -0.04%     
==========================================
  Files         373      373              
  Lines       14534    14534              
  Branches     2764     2764              
==========================================
- Hits        12226    12221       -5     
- Misses       1737     1742       +5     
  Partials      571      571              
Impacted Files Coverage Δ
src/docfx/lib/git/GitUtility.cs 55.85% <0.00%> (-4.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe66886...8a30804. Read the comment docs.

@ghost
Copy link

ghost commented Mar 4, 2021

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

@yufeih yufeih merged commit b1307cc into dotnet:v3 Mar 4, 2021
@yufeih yufeih deleted the warnAsError branch March 4, 2021 04:06
fkpwolf pushed a commit to fkpwolf/docfx that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants