Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that command line options (/nowarn and /warnaserror) override editorconfig and global config #48125

Merged
merged 5 commits into from
Sep 30, 2020
Merged

Ensure that command line options (/nowarn and /warnaserror) override editorconfig and global config #48125

merged 5 commits into from
Sep 30, 2020

Conversation

mavasani
Copy link
Contributor

Fixes #43051

This was referenced Sep 28, 2020
Closed
Closed
@mavasani mavasani marked this pull request as ready for review September 29, 2020 01:26
@mavasani mavasani requested review from a team as code owners September 29, 2020 01:26
@mavasani mavasani added this to the 16.9 milestone Sep 29, 2020
@mavasani
Copy link
Contributor Author

@dotnet/roslyn-compiler for an additional review

333fred
333fred approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 5)

@mavasani
Copy link
Contributor Author

Thanks all!

@mavasani mavasani merged commit bc8c26a into dotnet:master Sep 30, 2020
@ghost ghost modified the milestones: 16.9, Next Sep 30, 2020
@mavasani mavasani deleted the CommandLineOverride branch September 30, 2020 23:37
@Cosifne Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020
@mavasani mavasani mentioned this pull request Oct 23, 2020
Closed
@maxild maxild mentioned this pull request Jan 12, 2021
Closed
@Youssef1313 Youssef1313 mentioned this pull request Jul 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsienki chsienki chsienki approved these changes

@333fred 333fred 333fred approved these changes

@jaredpar jaredpar Awaiting requested review from jaredpar

Assignees
No one assigned
Labels
Area-Analyzers Area-Compilers
Projects
None yet
Milestone
16.9.P1
Development

Successfully merging this pull request may close these issues.

TreatWarningsAsErrors ignored when severity set in EditorConfig
4 participants
@mavasani @333fred @chsienki @Cosifne