Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh/only forbid uppercase ascii #3416

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Enh/only forbid uppercase ascii #3416

merged 2 commits into from
Jan 24, 2024

Conversation

fontanierh
Copy link
Contributor

Description

  • We don't allow uppsecase letters in column names (in core). However, we want to allow symbols numbers etc.. The condition was broken because it required only ascii lowercase
  • in CSV upload, if upserting rows fails, we want to delete the table we just created, otherwise we end up with an empty useless table and when the user attempts to re-upload it then it fails.

Risk

blast radius limited to tables queries.

Deploy Plan

simple core + front deploy

@fontanierh fontanierh requested a review from spolu January 24, 2024 17:04
@fontanierh fontanierh merged commit 803e85b into main Jan 24, 2024
3 checks passed
@fontanierh fontanierh deleted the enh/only-forbid-uppercase-ascii branch January 24, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolu spolu spolu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fontanierh @spolu