Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/add confluence log #6731

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Enh/add confluence log #6731

merged 2 commits into from
Aug 10, 2024

Conversation

fontanierh
Copy link
Contributor

@fontanierh fontanierh commented Aug 10, 2024

Description

We don't know which one is stuck

Risk

Deploy Plan

@fontanierh fontanierh requested a review from flvndvd August 10, 2024 09:28
@fontanierh fontanierh merged commit 8a59c6f into main Aug 10, 2024
5 checks passed
@fontanierh fontanierh deleted the enh/add-confluence-log branch August 10, 2024 09:28

The content should be responsive and should not have fixed widths or heights. The component should be able to adapt to different screen sizes.
The content should never overflow the viewport and should never have horizontal or vertical scrollbars.

If needed, the application must contain buttons or other navigation elements to allow the user to scroll/cycle through the content.
Never use tailwind's specific values like \`h-[600px]\`.
Tailwind's arbitrary values like \`h-[600px]\` should never be used, as they are not available in the visualization environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this is already in prod, just didn't rebase this branch)

Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

albandum pushed a commit that referenced this pull request Aug 28, 2024
* enh(viz prompt): reduce likelihood of bad tw class

* enh: add a log for confluence report

---------

Co-authored-by: Henry Fontanier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants