Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/add confluence log #6731

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Enh/add confluence log #6731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63a3880
enh(viz prompt): reduce likelihood of bad tw class
Aug 9, 2024
f584dd5
enh: add a log for confluence report
Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions connectors/src/connectors/confluence/temporal/activities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,19 +659,26 @@ export async function confluenceGetReportPersonalActionActivity(
});

if (oldestPageSync) {
const client = await getConfluenceClient({}, connector);
try {
const client = await getConfluenceClient({}, connector);

const result = await client.reportAccount({
accountId: userAccountId,
updatedAt: oldestPageSync.lastVisitedAt,
});
const result = await client.reportAccount({
accountId: userAccountId,
updatedAt: oldestPageSync.lastVisitedAt,
});

if (result && result.status === "closed") {
logger.info(
{ connectorId, userAccountId },
"Confluence report accounts API, account closed."
if (result && result.status === "closed") {
logger.info(
{ connectorId, userAccountId },
"Confluence report accounts API, account closed."
);
return true;
}
} catch (err) {
logger.error(
{ connectorId, userAccountId, err },
"Error while reporting Confluence account."
);
return true;
}
}

Expand Down
14 changes: 5 additions & 9 deletions front/lib/api/assistant/visualization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,23 +119,19 @@ The generated component should not have any required props / parameters.



### Responsiveness
### Responsiveness and Styling

The content should be responsive and should not have fixed widths or heights. The component should be able to adapt to different screen sizes.
The content should never overflow the viewport and should never have horizontal or vertical scrollbars.

If needed, the application must contain buttons or other navigation elements to allow the user to scroll/cycle through the content.
Never use tailwind's specific values like \`h-[600px]\`.
Tailwind's arbitrary values like \`h-[600px]\` should never be used, as they are not available in the visualization environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this is already in prod, just didn't rebase this branch)

No tailwind class that include a square bracket should be used in the visualization, they will cause the visualization to not render at all.
When arbitrary / specific values are necessary, regular CSS (using the \`style\` prop) can be used as a fallback.
For all other styles, Tailwind CSS classes should be preferred

Always add padding to the content (both horizontal and vertical) to make it look better and make sure the labels are fully visible.



### Styling

For all other styles, Tailwind CSS classes should be preferred. Arbitrary values should not be used, e.g. \`h-[600px]\`. When arbitrary / specific values are necessary, regular CSS (using the \`style\` prop) can be used as a fallback.



### Using files from the conversation

Expand Down
Loading