Data source / vaults navigation #6745
Conversation
| <Item.List> | ||
| {vaults.map((vault) => ( | ||
| <Fragment key={`vault-${vault.sId}`}> | ||
| <Item.SectionHeader |
There was a problem hiding this comment.
We should not have one section header per vault , there's one single private section with all private vaults inside
I also think the section headers order is defined by the ui (system, shared then private ), it should not rely on the api return
There was a problem hiding this comment.
Ok I was gonna change the API to return in the right order, but let me do it on the UI side.
There was a problem hiding this comment.
👍
Still we have one section header per vault, instead of a single "private" section :
There was a problem hiding this comment.
Oh I see. Should be fixed.
| @@ -0,0 +1,81 @@ | |||
| import type { DataSourceViewType, UserType, VaultType } from "@dust-tt/types"; | |||
There was a problem hiding this comment.
Can we stuck with [dsvId] out of consistency across the entire codebase 🙏
Same for the other endpoint?
There was a problem hiding this comment.
In general we do [xId]/index.tsx I believe? but less important imho
* Bump sparkle to 0.2.204 * Add feature flag + data sources tab * Add data sources / vaults navigation * Unfold ancestor items * Address comments from review * Address comments from review
Description
See figma here.
This PR introduces a new "Data Sources" tab in the menu, which becomes visible when the feature flag is enabled. This tab will be accessible to all users, with the content displayed according to their permissions. It also includes the implementation of side navigation, which is synchronized with the router to ensure the side navigation and the page on the right remain consistent. Currently, only the
globalandregularvaults will be displayed, with thesystemvault to be added in a subsequent PR. I also added skeleton pages so we can start parallelizing the work.The navigation leverages the Layout Pattern from NextJS to avoid re-rendering the navigation every time. The breadcrumb (not yet implemented will also be included in this
VaultLayout.Risk
Low risk, everything is gated behind a FF.
Deploy Plan