Ed nav item update #9133
Merged
Ed nav item update #9133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plitButton - Consolidated button sizes by adding 'mini' to BUTTON_SIZES and removing separate MINI_BUTTON_SIZE handling - Removed MiniButton component and updated references to utilize Button with 'mini' size - Introduced FlexSplitButton as a new component for split button functionality, replacing SplitButton2 - Updated import statements to reflect the removal of MiniButton and SplitButton2, adding the new FlexSplitButton - Modified Playground.stories.tsx to demonstrate the new FlexSplitButton usage with 'mini' button size
- Removed 'size' prop from MetaButtonProps interface, aligning it with buttonVariants - Updated ButtonProps to inherit changes from MetaButtonProps, dropping 'size' - Replaced MiniButton with Button component and added 'size' prop inline in NavigationList - Modified SplitButton to default 'size' prop to undefined if not provided
JulesBelveze
force-pushed
the
EdNavItemUpdate
branch
from
53833e9 to
de8ba95
Compare
…nt classNames - Expand ternary operations in `FeedbackSelector.tsx` for `className` prop to enhance code clarity [sparkle] - refactor: remove deprecated SidebarMenuButton component - Delete the commented-out SidebarMenuButton component from `NavigationList.tsx` as it is no longer used
- Introduces `hideScrollBar` as an optional boolean prop to allow conditional rendering of scrollbar - The ScrollArea component now can be used without displaying its scrollbar for a cleaner design when necessary
- Make ScrollAreaProps available for import in other components or modules
JulesBelveze
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Risk
Potential break on NavigationItem