-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor whitelisted_addresses #392
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,7 @@ | ||
syntax = "proto3"; | ||
package rollapp.denommetadata.types; | ||
|
||
import "gogoproto/gogo.proto"; | ||
import "denommetadata/params.proto"; | ||
|
||
option go_package = "github.com/dymensionxyz/dymension-rdk/x/denommetadata/types"; | ||
|
||
// GenesisState defines the test module's genesis state. | ||
message GenesisState { | ||
// params are all parameters for the module | ||
Params params = 1 [ (gogoproto.nullable) = false ]; | ||
} | ||
message GenesisState {} | ||
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -8,13 +8,13 @@ option go_package = "github.com/dymensionxyz/dymension-rdk/x/hub-genesis/types"; | |||||
|
||||||
// State holds the state of the genesis event | ||||||
message State { | ||||||
// is_locked is a boolean that indicates if the genesis event has occured | ||||||
bool is_locked = 1; | ||||||
|
||||||
// genesis_tokens is the list of tokens that are expected to be locked on genesis event | ||||||
repeated cosmos.base.v1beta1.Coin genesis_tokens = 2 [ | ||||||
(gogoproto.nullable) = false, | ||||||
(gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins" | ||||||
]; | ||||||
// is_locked is a boolean that indicates if the genesis event has occured | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
bool is_locked = 1; | ||||||
|
||||||
// genesis_tokens is the list of tokens that are expected to be locked on | ||||||
// genesis event | ||||||
repeated cosmos.base.v1beta1.Coin genesis_tokens = 2 [ | ||||||
(gogoproto.nullable) = false, | ||||||
(gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins" | ||||||
]; | ||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
syntax = "proto3"; | ||
package rollapp.sequencers.types; | ||
|
||
import "gogoproto/gogo.proto"; | ||
import "sequencers/permission.proto"; | ||
|
||
option go_package = "github.com/dymensionxyz/dymension-rdk/x/sequencers/types"; | ||
|
||
message GrantPermissionsProposal { | ||
option (gogoproto.equal) = true; | ||
option (gogoproto.goproto_getters) = false; | ||
option (gogoproto.goproto_stringer) = false; | ||
|
||
string title = 1; | ||
string description = 2; | ||
|
||
AddressPermissions address_permissions = 3 [ (gogoproto.nullable) = false ]; | ||
} | ||
|
||
message RevokePermissionsProposal { | ||
option (gogoproto.equal) = true; | ||
option (gogoproto.goproto_getters) = false; | ||
option (gogoproto.goproto_stringer) = false; | ||
|
||
string title = 1; | ||
string description = 2; | ||
|
||
AddressPermissions address_permissions = 3 [ (gogoproto.nullable) = false ]; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
syntax = "proto3"; | ||
package rollapp.sequencers.types; | ||
|
||
import "gogoproto/gogo.proto"; | ||
|
||
// this line is used by starport scaffolding # genesis/proto/import | ||
|
||
option go_package = "github.com/dymensionxyz/dymension-rdk/x/sequencers/types"; | ||
|
||
message AddressPermissions { | ||
option (gogoproto.equal) = true; | ||
|
||
string address = 1 [ (gogoproto.moretags) = "yaml:\"address\"" ]; | ||
// list of the module name that addresses have permission to execute msg | ||
Permissions permissions = 2 [ | ||
(gogoproto.moretags) = "yaml:\"permissions\"", | ||
(gogoproto.nullable) = false | ||
]; | ||
} | ||
|
||
message Permissions { | ||
option (gogoproto.equal) = true; | ||
|
||
repeated string permissions = 1 | ||
[ (gogoproto.moretags) = "yaml:\"permissions\"" ]; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is empty, why do we need it at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep it as it's the cosmos-sdk standard, and in case we need to store some states in the future