Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20509] Update repository for Fast DDS 3.0.0 compatibility #111

Merged
merged 53 commits into from
Sep 10, 2024
Merged

[20509] Update repository for Fast DDS 3.0.0 compatibility #111

merged 53 commits into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. Update repository for FastDDS 3.0.0 compatibility 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8c6ba46 View commit details
    Browse the repository at this point in the history

  2. Fix tests and first approximation to change Dynamic Types 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    fb76564 View commit details
    Browse the repository at this point in the history

  3. Fix DynTypesParticipant::on_type_discovery_ callback to register type… 

    …_name-type_id tuple and some other minor changes

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1881f1b View commit details
    Browse the repository at this point in the history

  4. Change DynTypesParticipant to use RTPS Participant callbacks 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4896356 View commit details
    Browse the repository at this point in the history

  5. Regenarate types 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    719ab7d View commit details
    Browse the repository at this point in the history

  6. Add TypeIdentifiers to DdsTopic in order to pass the TypeInformation … 

    …to RTPS Writer/Reader

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b3fa7e7 View commit details
    Browse the repository at this point in the history

  7. Apply suggested changes 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    df5125e View commit details
    Browse the repository at this point in the history

  8. Apply suggested changes 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4a516a8 View commit details
    Browse the repository at this point in the history

  9. Regenerate types 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    45b0a98 View commit details
    Browse the repository at this point in the history

  10. Fix compilation after rebase to fastdds master 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    848fc99 View commit details
    Browse the repository at this point in the history

  11. Continue rebasing to FastDDS master 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    92917c3 View commit details
    Browse the repository at this point in the history

  12. Change .h headers to .hpp and regenerate types 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1648698 View commit details
    Browse the repository at this point in the history

  13. Update repository with new changes in Fast DDS 3.x 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1a02e76 View commit details
    Browse the repository at this point in the history

  14. Remove DynamicType to IDL serialization from DDSPipe 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    87734a0 View commit details
    Browse the repository at this point in the history

  15. Delete public functions in PayloadPool inherited from IPayloadPool an… 

    …d add missing tests in CMake file

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0ca4be6 View commit details
    Browse the repository at this point in the history

  16. Apply suggested changes 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0889756 View commit details
    Browse the repository at this point in the history

  17. Adjust to TopicDataType refactor and removal of WriterProxyData/Reade… 

    …rProxyData from public API

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2ceb0de View commit details
    Browse the repository at this point in the history

  18. Update after refactor in Participant discovery information 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c53312a View commit details
    Browse the repository at this point in the history

  19. Update after TopicAttributes removal from public API 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    32ae1e8 View commit details
    Browse the repository at this point in the history

  20. Regenerate types 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    54db70a View commit details
    Browse the repository at this point in the history

  21. Fix TopicDescription in CommonReader and CommonWriter 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f44cbb1 View commit details
    Browse the repository at this point in the history

  22. Apply suggested changes 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7374975 View commit details
    Browse the repository at this point in the history

  23. Remove GuidPrefix attribute from DiscoveryServerConnectionAddress 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6be6daf View commit details
    Browse the repository at this point in the history

  24. Remove is_keyed_ method after Publication/SubscriptionBuiltinTopicDat… 

    …a update in Fast DDS

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    edb5450 View commit details
    Browse the repository at this point in the history

  25. Fix CacheChangePool after rebase 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    70e8001 View commit details
    Browse the repository at this point in the history

  26. Fix tests 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bd98813 View commit details
    Browse the repository at this point in the history

  27. Fix uncrustify 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9126924 View commit details
    Browse the repository at this point in the history

  28. Free allocated memory in PayloadPool::release_ 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d0a5ad2 View commit details
    Browse the repository at this point in the history

  29. Fill TypeInformation in Topic Description just from complete TypeIden… 

    …tifier in CommonWriter (already done in CommonReader)

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    becfdea View commit details
    Browse the repository at this point in the history

  30. Apply suggested changes 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9b2873d View commit details
    Browse the repository at this point in the history

  31. Make payload_owner=nullptr in PayloadPool::release_ before empty() to… 

    … avoid assertion failure

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a35d46e View commit details
    Browse the repository at this point in the history

  32. Add assertion making sure TypeIdentifier is complete before calling a… 

    …dd_schema

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a064438 View commit details
    Browse the repository at this point in the history

  33. Apply suggested changes 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9fc0456 View commit details
    Browse the repository at this point in the history

  34. Refactor rtps participants reckon_participant_attributes_ 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    34c57cd View commit details
    Browse the repository at this point in the history

  35. Accept v6 interfaces and interface names in whitelist (#128) 

    Signed-off-by: Juan Lopez Fernandez <[email protected]>
    @juanlofer-eprosima @LuciaEchevarria99
    juanlofer-eprosima authored and LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3d370e7 View commit details
    Browse the repository at this point in the history

  36. Make DiscoveryServer servers' guid prefix optional (#129) 

    * Make DiscoveryServer servers' guid prefix optional

Signed-off-by: Juan Lopez Fernandez <[email protected]>

* Raise YAML reader version

Signed-off-by: Juan Lopez Fernandez <[email protected]>

* BONUS: improve participant discovery traces

Signed-off-by: Juan Lopez Fernandez <[email protected]>

---------

Signed-off-by: Juan Lopez Fernandez <[email protected]>
    @juanlofer-eprosima @LuciaEchevarria99
    juanlofer-eprosima authored and LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5cce977 View commit details
    Browse the repository at this point in the history

  37. Add missing suggested changes 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1a0295c View commit details
    Browse the repository at this point in the history

  38. Correct type_kind_to_str output for TK_CHAR8 case 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    80cca3a View commit details
    Browse the repository at this point in the history

  39. Remove unnecessary CacheChange include 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2df989c View commit details
    Browse the repository at this point in the history

  40. Implement add_qos_properties_ in reckon_participant_qos_ 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9534f79 View commit details
    Browse the repository at this point in the history

  41. Remove Fast-DDS API ReturnCode explanation in PayloadPoolMediator::write 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    44c01d7 View commit details
    Browse the repository at this point in the history

  42. Change name ip_configuration -> initial_peers_configuration 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7e12adc View commit details
    Browse the repository at this point in the history

  43. Change name ds_configuration -> discovery_server_configuration 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3490845 View commit details
    Browse the repository at this point in the history

  44. Use dynamic_pointer_cast instead of static_pointer_cast in reckon_par… 

    …ticipant_attributes_

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    74daf38 View commit details
    Browse the repository at this point in the history

  45. Change function descriptions in CommonParticipant 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    aac932c View commit details
    Browse the repository at this point in the history

  46. CHange char sequence message in tests 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    225fdb6 View commit details
    Browse the repository at this point in the history

  47. Add clarification comment in TopicDataType::compute_key(SerializedPay… 

    …load_t, ...)

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    aa1a682 View commit details
    Browse the repository at this point in the history

  48. Fix YamlGetEntityGuidPrefixTest.get_guidprefix_explicitly test 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    fa147dc View commit details
    Browse the repository at this point in the history

  49. Add comment clarifying the order of TypeIdentifiers (complete and min… 

    …imal) in DdsTopic.type_identifiers

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d2fa3fa View commit details
    Browse the repository at this point in the history

  50. Fix Windows compilation 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3012a05 View commit details
    Browse the repository at this point in the history

  51. Uncrustify 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    75062c8 View commit details
    Browse the repository at this point in the history

  52. Check if ParticipantConfiguration is nullptr after cast in reckon_par… 

    …ticipant_attributes_

Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b0c8072 View commit details
    Browse the repository at this point in the history

  53. Fix uncrustify 

    Signed-off-by: Lucia Echevarria <[email protected]>
    @LuciaEchevarria99
    LuciaEchevarria99 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5154606 View commit details
    Browse the repository at this point in the history