Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20509] Update repository for Fast DDS 3.0.0 compatibility #111

Merged
merged 53 commits into from
Sep 10, 2024
Merged

[20509] Update repository for Fast DDS 3.0.0 compatibility #111

merged 53 commits into from
Sep 10, 2024

Conversation

LuciaEchevarria99
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 commented Apr 22, 2024 •
edited by juanlofer-eprosima
Loading

@rsanchez15 rsanchez15 changed the title Update repository for FastDDS 3.0.0 compatibility Update repository for Fast DDS 3.0.0 compatibility Apr 30, 2024
@LuciaEchevarria99 LuciaEchevarria99 mentioned this pull request May 16, 2024
Closed
@LuciaEchevarria99 LuciaEchevarria99 changed the base branch from main to ci/bump-v3 May 17, 2024 09:04
@LuciaEchevarria99 LuciaEchevarria99 mentioned this pull request May 20, 2024
Merged
@rsanchez15 rsanchez15 changed the base branch from ci/bump-v3 to 1.x-devel June 4, 2024 07:21
Tempate
Tempate suggested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Tempate Tempate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks for your hard work. Keep it up 🥇

ddspipe_core/src/cpp/types/topic/dds/DdsTopic.cpp Outdated Show resolved Hide resolved
..._participants/include/ddspipe_participants/participant/dynamic_types/DynTypesParticipant.hpp Outdated Show resolved Hide resolved
ddspipe_participants/include/ddspipe_participants/participant/dds/CommonParticipant.hpp Outdated Show resolved Hide resolved
ddspipe_participants/src/cpp/participant/dds/CommonParticipant.cpp Outdated Show resolved Hide resolved
ddspipe_participants/src/cpp/participant/dynamic_types/DynTypesParticipant.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved
ddspipe_core/src/cpp/types/dynamic_types/schema_msg.cpp Show resolved Hide resolved
@LuciaEchevarria99 LuciaEchevarria99 mentioned this pull request Jun 18, 2024
Merged
@LuciaEchevarria99 LuciaEchevarria99 changed the title Update repository for Fast DDS 3.0.0 compatibility [20509] Update repository for Fast DDS 3.0.0 compatibility Jun 18, 2024
Tempate
Tempate suggested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@Tempate Tempate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to find and remove the const_casts made explicitly to be able to write. They aren't necessary any more.

Carlosespicur
Carlosespicur reviewed Jul 15, 2024
View reviewed changes
ddspipe_core/include/ddspipe_core/efficiency/payload/PayloadPool.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/efficiency/payload/PayloadPool.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/efficiency/payload/PayloadPool.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/logging/DdsLogConsumer.hpp Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/monitoring/producers/StatusMonitorProducer.hpp Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/monitoring/producers/TopicsMonitorProducer.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/monitoring/producers/TopicsMonitorProducer.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/types/dds/DomainId.hpp Outdated Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/types/dds/Payload.hpp Show resolved Hide resolved
ddspipe_core/include/ddspipe_core/types/dds/SpecificEndpointQoS.hpp Outdated Show resolved Hide resolved
@juanlofer-eprosima @LuciaEchevarria99
Accept v6 interfaces and interface names in whitelist (#128)
3d370e7 
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@juanlofer-eprosima @LuciaEchevarria99
Make DiscoveryServer servers' guid prefix optional (#129)
5cce977 
* Make DiscoveryServer servers' guid prefix optional

Signed-off-by: Juan Lopez Fernandez <[email protected]>

* Raise YAML reader version

Signed-off-by: Juan Lopez Fernandez <[email protected]>

* BONUS: improve participant discovery traces

Signed-off-by: Juan Lopez Fernandez <[email protected]>

---------

Signed-off-by: Juan Lopez Fernandez <[email protected]>
@LuciaEchevarria99
Add missing suggested changes
1a0295c 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Correct type_kind_to_str output for TK_CHAR8 case
80cca3a 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Remove unnecessary CacheChange include
2df989c 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Implement add_qos_properties_ in reckon_participant_qos_
9534f79 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Remove Fast-DDS API ReturnCode explanation in PayloadPoolMediator::write
44c01d7 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Change name ip_configuration -> initial_peers_configuration
7e12adc 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Change name ds_configuration -> discovery_server_configuration
3490845 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Use dynamic_pointer_cast instead of static_pointer_cast in reckon_par…
74daf38 
…ticipant_attributes_

Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Change function descriptions in CommonParticipant
aac932c 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
CHange char sequence message in tests
225fdb6 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Add clarification comment in TopicDataType::compute_key(SerializedPay…
aa1a682 
…load_t, ...)

Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Fix YamlGetEntityGuidPrefixTest.get_guidprefix_explicitly test
fa147dc 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Add comment clarifying the order of TypeIdentifiers (complete and min…
d2fa3fa 
…imal) in DdsTopic.type_identifiers

Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Fix Windows compilation
3012a05 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Uncrustify
75062c8 
Signed-off-by: Lucia Echevarria <[email protected]>
@LuciaEchevarria99
Fix uncrustify
5154606 
Signed-off-by: Lucia Echevarria <[email protected]>
@rsanchez15 rsanchez15 merged commit 7fff9e9 into main Sep 10, 2024
16 of 17 checks passed
@rsanchez15 rsanchez15 deleted the integration/bump-3.0.0 branch September 10, 2024 14:00
@juanlofer-eprosima juanlofer-eprosima restored the integration/bump-3.0.0 branch September 13, 2024 07:28
@juanlofer-eprosima juanlofer-eprosima deleted the integration/bump-3.0.0 branch September 13, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tempate Tempate Tempate requested changes

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima requested changes

@Carlosespicur Carlosespicur Carlosespicur requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LuciaEchevarria99 @codecov-commenter @Tempate @juanlofer-eprosima @Carlosespicur @rsanchez15 @irenebm