Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21244] Add utils script for type generation #93

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 5, 2024

Description

This PR performs a cherry pick to the commit in master that introduced the utils type generator.
It also introduces some changes (as the possibility to add an argument to the script for CDR generation, related with some CI refactor Fast DDS Gen PRS:)

Those PRs need to be updated with the corresponding CDR version:

  • Fast DDS Gen 3.3.x (Fast DDS 2.14.x) -> cdr-both
  • Fast DDS Gen 3.2.x (Fast DDS 2.13.x) -> cdr-both
  • Fast DDS Gen 2.5.x (Fast DDS 2.10.x) -> (no arg provided)
  • Fast DDS Gen 2.1.x (Fast DDS 2.6.x) -> (no arg provided)

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The added tests pass locally.
  • N/A Changes are backwards compatible.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Jul 5, 2024
@JesusPoderoso JesusPoderoso added this to the v1.2.3 milestone Jul 5, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 5, 2024
@JesusPoderoso JesusPoderoso removed the needs-review PR that is ready to be reviewed label Jul 9, 2024
@EduPonz EduPonz added the skip-ci Automatically pass CI label Jul 9, 2024
@JesusPoderoso JesusPoderoso merged commit 26d6a82 into 1.2.x Jul 9, 2024
2 checks passed
@JesusPoderoso JesusPoderoso deleted the hotfix/idl_script branch July 9, 2024 14:57
JesusPoderoso added a commit that referenced this pull request Jul 22, 2024
* Refs #21183: Add type support regeneration script

Signed-off-by: eduponz <[email protected]>

* Refs #2124: Adjust script

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21244: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: eduponz <[email protected]>
JesusPoderoso added a commit that referenced this pull request Jul 22, 2024
* Refs #21183: Add type support regeneration script

Signed-off-by: eduponz <[email protected]>

* Refs #2124: Adjust script

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21244: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: eduponz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants