Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21535] Use eProsima-CI action to install Qt #5186

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[21535] Use eProsima-CI action to install Qt #5186

merged 1 commit into from
Sep 6, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Sep 2, 2024 •
edited
Loading

Description

This PR use a new eProsima-CI action to install Qt. This migration has been done in order to reach better scalability setting all the external action in the CI repo, so any change required in the action only needs to be done there.

Related PRs:

Note: As part of a CI update, this PR needs to be backported also to 2.6.x.

@Mergifyio backport 2.14.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Sep 2, 2024
@JesusPoderoso JesusPoderoso added this to the v3.0.1 milestone Sep 2, 2024
@JesusPoderoso JesusPoderoso self-assigned this Sep 2, 2024
This was referenced Sep 2, 2024
Merged
Closed
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 2, 2024
@JesusPoderoso JesusPoderoso mentioned this pull request Sep 2, 2024
Merged
6 tasks
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima September 2, 2024 14:44
@rsanchez15 rsanchez15 merged commit 70314ce into master Sep 6, 2024
25 of 31 checks passed
@rsanchez15 rsanchez15 deleted the feature/21535 branch September 6, 2024 06:48
@JesusPoderoso
Copy link
Contributor Author

@Mergifyio backport 2.14.x 2.10.x 2.6.x

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Sep 6, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 6, 2024 •
edited
Loading

backport 2.14.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 6, 2024
@JesusPoderoso @mergify
Use eProsima-CI action to install Qt (#5186)
c0cd1b0 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 70314ce)
mergify bot pushed a commit that referenced this pull request Sep 6, 2024
@JesusPoderoso @mergify
Use eProsima-CI action to install Qt (#5186)
eddc565 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 70314ce)
mergify bot pushed a commit that referenced this pull request Sep 6, 2024
@JesusPoderoso @mergify
Use eProsima-CI action to install Qt (#5186)
055396c 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 70314ce)
This was referenced Sep 6, 2024
Merged
Merged
Open
Merged
Merged
@mergify mergify bot mentioned this pull request Sep 6, 2024
Merged
6 tasks
paxifaer pushed a commit to paxifaer/Fast-DDS that referenced this pull request Sep 7, 2024
@JesusPoderoso @paxifaer
Use eProsima-CI action to install Qt (eProsima#5186)
8063e60 
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: paxifaer <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Sep 11, 2024
@mergify @JesusPoderoso
Use eProsima-CI action to install Qt (#5186) (#5193)
e71ffb5 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 70314ce)

Co-authored-by: Jesús Poderoso <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Sep 12, 2024
@mergify @JesusPoderoso
Use eProsima-CI action to install Qt (#5186) (#5192)
f5bca04 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 70314ce)

Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsanchez15 rsanchez15 rsanchez15 approved these changes

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @rsanchez15