Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x.x] Switch CI from Temurin to Liberica #5468

Merged

Conversation

adamretter
Copy link
Contributor

Backport of #5466

Liberica should still provide JDK 8 on macOS

@adamretter adamretter added the ci issues related to continuous integration label Oct 2, 2024
@adamretter adamretter requested review from reinhapa and dizzzz October 2, 2024 17:01
@adamretter adamretter added this to the eXist-4.11.1 milestone Oct 2, 2024
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting build error.... as it is not related to the change.

   [junit] 1407 [WARN] DefaultCacheManager: The cacheSize="256" setting in conf.xml is too large. Java has only 466432k available. Cache manager will not use more than 155477k to avoid memory issues which may lead to database corruptions.
Error: nit] 1704 [ERROR] PluginsManagerImpl: java.lang.ClassNotFoundException: org.exist.storage.md.MDStorageManager

@adamretter
Copy link
Contributor Author

WARN] DefaultCacheManager: The cacheSize="256" setting in conf.xml is too large. Java has only 466432k available. Cache manager will not use more than 155477k to avoid memory issues which may lead to database corruptions.

@dizzzz I think this one may be due to the limited amount of RAM available in CI and that we need not worry about it.

Error: nit] 1704 [ERROR] PluginsManagerImpl: java.lang.ClassNotFoundException: org.exist.storage.md.MDStorageManager

@dizzzz I have appended a commit to change this from an Error into a Warning in the log.

@dizzzz
Copy link
Member

dizzzz commented Oct 3, 2024

@adamretter could it be that a 32bit VM is used?

@adamretter
Copy link
Contributor Author

@adamretter could it be that a 32bit VM is used?

No. I don't think so

@adamretter
Copy link
Contributor Author

@dizzzz @reinhapa I believe this is now ready to merge please?

@reinhapa
Copy link
Member

reinhapa commented Oct 9, 2024

@adamretter the windows build still fails. Wilk this be resolve with the folllow up restore output change?

@adamretter adamretter force-pushed the 4.x.x/hotfix/ci-jdk-8-macos branch from 0414b32 to d2b1067 Compare October 10, 2024 08:36
@adamretter
Copy link
Contributor Author

adamretter commented Oct 10, 2024

the windows build still fails. Wilk this be resolve with the folllow up restore output change?

@reinhapa I didn't have the Ant script quite correct for passing the property to disable the journal recovery log output. I have fixed that now, and CI is all passing now :-)

@reinhapa reinhapa requested a review from dizzzz October 10, 2024 11:46
@dizzzz dizzzz merged commit e625413 into eXist-db:develop-4.x.x Oct 10, 2024
4 checks passed
@adamretter adamretter deleted the 4.x.x/hotfix/ci-jdk-8-macos branch November 28, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants