Use pycodestyle in CI and fix style issues in EasyConfigs #21405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
framework uses pycodestyle if available and pep8 only as a fallback and later likely not at all (pep8 was renamed to pycodestyle and the existing package is no longer updated) So we need to check for either both or (more future proof) only for pycodestyle.
pep8 has bugs which makes it miss many issues like long-lines in docstrings. This might make the tests fail if both packages are available as framework prefers the newer pycodestyle.
These make the test fail, so fix them.
Flamefire
force-pushed
the
codestyle
branch
from
4e14c69
to
3e3727a
Compare
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
framework uses pycodestyle if available and pep8 only as a fallback and later likely not at all (pep8 was renamed to pycodestyle and the existing package is no longer updated)
So we need to check for either both or (more future proof) only for pycodestyle.
Install it in CI to actually test it and fix the found issues to make the test pass again.
Requires one of: