Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pycodestyle in CI and fix style issues in EasyConfigs #21405

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Use pycodestyle in CI and fix style issues in EasyConfigs #21405

wants to merge 3 commits into from

Commits on Sep 13, 2024

  1. Check for pycodestyle in styletests 

    framework uses pycodestyle if available and pep8 only as a fallback and
later likely not at all (pep8 was renamed to pycodestyle and the
existing package is no longer updated)
So we need to check for either both or (more future proof) only for
pycodestyle.
    @Flamefire
    Flamefire committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f191a39 View commit details
    Browse the repository at this point in the history

  2. Install pycodestyle in CI 

    pep8 has bugs which makes it miss many issues like long-lines in docstrings.
This might make the tests fail if both packages are available as
framework prefers the newer pycodestyle.
    @Flamefire
    Flamefire committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    87dea8f View commit details
    Browse the repository at this point in the history

  3. Fix code style issues in existing ECs 

    These make the test fail, so fix them.
    @Flamefire
    Flamefire committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3e3727a View commit details
    Browse the repository at this point in the history