Changes to allow debug memory problems #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cpp types in method callers. remove assert and debug print noise.
…uct class parameter to be able to pass null. handle name clash between lowercased method and property names. remove some brokens and add others.
…constructors. remove many fixed brokens.
…ration. fix global function symbol collision between C and C++.
…fix broken array parameters.
jerstlouis
force-pushed
the
latest
branch
11 times, most recently
from
5a88997 to
414480b
Compare
|
Hi @mingodad, wondering if you had a chance to figure out what issue that you ran into was? As I had mentioned, I think it likely had to do with a memory management mix-up. In your PR, I see usage of malloc_usable_size() but that will not work properly as that does not return the size that was requested. (I have made that mistake before). We cannot merge these changes to use regular malloc/calloc/realloc when _DEBUG is defined because of this, and also because the code should go through the regular pathways which supports our own MemoryGuard memory checker and the eC which makes a huge performance difference for small allocation on Windows platforms. Please let me know if I can be of further help. |
jerstlouis
force-pushed
the
latest
branch
8 times, most recently
from
1028167 to
7277524
Compare
jerstlouis
force-pushed
the
latest
branch
2 times, most recently
from
abe6262 to
171551b
Compare
jerstlouis
force-pushed
the
latest
branch
2 times, most recently
from
d7dcc75 to
adda21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usage: make V=1 DEBUG=1 DBGWRAPPER=valgrind DISABLE_MEMMGR=1 DESTDIR=$HOME/local