Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make integration test timeouts configurable #970

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Oct 25, 2024

Fixes: #969
Fixes: #971

Depending on platforms, the default timeouts used in the integration tests need to be adjusted. In order to prevent code modification, lets have the three currently available, high-level timeouts be configurable via tmt.

Local provisioning is considered dangerous since tmt v1.38.0 and causes the pipeline to fail. In order to be able to run BlueChi integration tests, lets enable it by setting the environment variable TMT_FEELING_SAFE via --feeling-safe CLI option in the GitHub workflow and via env variable in packit.
See:
teemtee/tmt#3282
https://tmt.readthedocs.io/en/stable/overview.html#variables

@coveralls
Copy link

coveralls commented Oct 25, 2024

Coverage Status

coverage: 83.286% (-0.1%) from 83.413%
when pulling 447b339 on engelmi:make-integration-test-timeouts-configurable
into 4fbfa95 on eclipse-bluechi:main.

@engelmi
Copy link
Member Author

engelmi commented Oct 25, 2024

/packit retest-failed

2 similar comments
@engelmi
Copy link
Member Author

engelmi commented Oct 25, 2024

/packit retest-failed

@engelmi
Copy link
Member Author

engelmi commented Oct 25, 2024

/packit retest-failed

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina
Copy link
Member

/packit retest-failed

Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi
Copy link
Member Author

engelmi commented Oct 28, 2024

Tests on testing farm are currently pretty bittle... lets give it another try.

@engelmi
Copy link
Member Author

engelmi commented Oct 28, 2024

/packit retest-failed

1 similar comment
@engelmi
Copy link
Member Author

engelmi commented Oct 28, 2024

/packit retest-failed

@engelmi
Copy link
Member Author

engelmi commented Oct 28, 2024

/packit test

Note: Seems like the copr builds are not available, so triggering packit doesn't work (the linked run was from 3 days ago). I resigned the commit to trigger the full flow again. If it fails again only in TF because of some infra setup, lets merge still.

@engelmi engelmi force-pushed the make-integration-test-timeouts-configurable branch from 9893d4c to 6dc1687 Compare October 28, 2024 08:49
@engelmi engelmi force-pushed the make-integration-test-timeouts-configurable branch 3 times, most recently from d9d6f3a to 72bd4b8 Compare October 28, 2024 10:46
@engelmi
Copy link
Member Author

engelmi commented Oct 28, 2024

/packit retest-failed

@mkemel
Copy link
Member

mkemel commented Oct 28, 2024

/packit retest-failed

Fixes: eclipse-bluechi#969

Depending on platforms, the default timeouts used in the integration
tests need to be adjusted. In order to prevent code modification, lets
have the three currently available, high-level timeouts be configurable
via tmt.

Signed-off-by: Michael Engel <[email protected]>
Fixes: eclipse-bluechi#971

Local provisioning is considered dangerous since tmt v1.38.0 and
causes the pipeline to fail. In order to be able to run BlueChi
integration tests, lets enable it by setting the environment
variable TMT_FEELING_SAFE via --feeling-safe CLI option in the
GitHub workflow and setting the env variable in packit.
See:
teemtee/tmt#3282
https://tmt.readthedocs.io/en/stable/overview.html#variables

Signed-off-by: Michael Engel <[email protected]>
@engelmi engelmi force-pushed the make-integration-test-timeouts-configurable branch from 72bd4b8 to 447b339 Compare October 28, 2024 12:33
@engelmi
Copy link
Member Author

engelmi commented Oct 28, 2024

/packit retest-failed

@engelmi
Copy link
Member Author

engelmi commented Oct 28, 2024

Retriggered the pipeline again to see if the flaky tests are passing now.
Investigation (and hopefully fixing) of the flakyness will be done in #972.

@engelmi engelmi merged commit 93644fb into eclipse-bluechi:main Oct 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix integration tests in GH action Make timeouts used in integration tests configurable
4 participants