Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest Theia community release: v1.49.1 #1085

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

bhufmann
Copy link
Collaborator

Update to Theia community release version 1.49.1

Signed-off-by: Bernd Hufmann [email protected]

@bhufmann
Copy link
Collaborator Author

Opening a trace from the File Explorer with right-mouse click on trace Open With ... -> Trace Viewer is not working anymore. Theia changed to use a quick pick menu and the Trace Viewer doesn't show up there.

See eclipse-theia/theia#13573 for the change.

It needs to be investigated how to fix it on the trace extension side.

@bhufmann
Copy link
Collaborator Author

I noticed also that the progress message boxes are not shown (during start of trace server or opening a trace)

@bhufmann
Copy link
Collaborator Author

I noticed also that the progress message boxes are not shown (during start of trace server or opening a trace)

This issue is also in master branch and not related by this upgrade patch.

Fix "Open With -> Trace Viewer" by using the new OpenWithService. The
old "Open With" implementation in Theia was changed in favor of this
new service, but it broke current behaviour.

eclipse-theia/theia#13573

Signed-off-by: Bernd Hufmann <[email protected]>
@marcdumais-work
Copy link
Contributor

IP ticket for the dependency that's failing the license check:
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15475

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Bernd!

I confirmed that the new code using the "openWithService" does the job, when opening a trace from the file navigator.

@bhufmann bhufmann merged commit 8c979dd into eclipse-cdt-cloud:master Jun 28, 2024
7 checks passed
@bhufmann bhufmann deleted the theia-release branch June 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants