docs: adds decision record about default datasource #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
requested review from
ndr-brt,
jimmarino and
paullatzelsperger
and removed request for
juliapampus
ndr-brt
approved these changes
Aug 1, 2023
jimmarino
approved these changes
Aug 1, 2023
|
|
||
| ## Rationale | ||
|
|
||
| Each SQL store implementation as of today needs to have at least one mandatory configuration |
There was a problem hiding this comment.
Suggested change
| Each SQL store implementation as of today needs to have at least one mandatory configuration | |
| Each SQL store implementation currently must have at least one mandatory configuration |
| Each SQL store implementation as of today needs to have at least one mandatory configuration | ||
| parameter `edc.datasource.<entity>.name` and then in case additional parameters as `url`, `user`, `password` and so on. | ||
|
|
||
| This is powerful for fine-grained configuration and deployment. For simpler case and scenario all the store should |
There was a problem hiding this comment.
Suggested change
| This is powerful for fine-grained configuration and deployment. For simpler case and scenario all the store should | |
| This is powerful for fine-grained configuration and deployment. For simpler cases and scenario all the stores should |
|
|
||
| ## Approach | ||
|
|
||
| All the SQL store extension will default to a common datasource name defined |
There was a problem hiding this comment.
Suggested change
| All the SQL store extension will default to a common datasource name defined | |
| All the SQL store extensions will default to a common datasource name defined |
|
Will amend this in the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds decision about default datasource
Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Ref #3337