-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adds decision record about default datasource #3346
Merged
wolf4ood
merged 1 commit into
eclipse-edc:main
from
wolf4ood:docs/decision_record_default_datasource
Aug 1, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
27 changes: 27 additions & 0 deletions
27
docs/developer/decision-records/2023-08-01-default-datasource/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,27 @@ | ||||||
# Default Datasource configuration | ||||||
|
||||||
## Decision | ||||||
|
||||||
All SQL store extensions, if the specific datasource name is not configured should fall back to the default one. | ||||||
|
||||||
## Rationale | ||||||
|
||||||
Each SQL store implementation as of today needs to have at least one mandatory configuration | ||||||
parameter `edc.datasource.<entity>.name` and then in case additional parameters as `url`, `user`, `password` and so on. | ||||||
|
||||||
This is powerful for fine-grained configuration and deployment. For simpler case and scenario all the store should | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
default to a common datasource name, that will be easier to configure. | ||||||
|
||||||
## Approach | ||||||
|
||||||
All the SQL store extension will default to a common datasource name defined | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
in `DataSourceRegistry#DEFAULT_DATASOURCE` (**default**) | ||||||
and then users can configure a single datasource like this: | ||||||
|
||||||
``` | ||||||
edc.datasource.default.user= | ||||||
edc.datasource.default.password= | ||||||
edc.datasource.default.url= | ||||||
... | ||||||
``` | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.