Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds decision record about default datasource #3346

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Default Datasource configuration

## Decision

All SQL store extensions, if the specific datasource name is not configured should fall back to the default one.

## Rationale

Each SQL store implementation as of today needs to have at least one mandatory configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Each SQL store implementation as of today needs to have at least one mandatory configuration
Each SQL store implementation currently must have at least one mandatory configuration

parameter `edc.datasource.<entity>.name` and then in case additional parameters as `url`, `user`, `password` and so on.

This is powerful for fine-grained configuration and deployment. For simpler case and scenario all the store should
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is powerful for fine-grained configuration and deployment. For simpler case and scenario all the store should
This is powerful for fine-grained configuration and deployment. For simpler cases and scenario all the stores should

default to a common datasource name, that will be easier to configure.

## Approach

All the SQL store extension will default to a common datasource name defined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All the SQL store extension will default to a common datasource name defined
All the SQL store extensions will default to a common datasource name defined

in `DataSourceRegistry#DEFAULT_DATASOURCE` (**default**)
and then users can configure a single datasource like this:

```
edc.datasource.default.user=
edc.datasource.default.password=
edc.datasource.default.url=
...
```

1 change: 1 addition & 0 deletions docs/developer/decision-records/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,4 @@
- [2023-06-30-allow-use-of-testcontainers](2023-06-30-allow-use-of-testcontainers/)
- [2023-06-30 Sync Commands](2023-07-19-sync-commands)
- [2023-06-30 State Machine guards](2023-07-20-state-machine-guards)
- [2023-08-01 Default datasource](2023-08-01-default-datasource)
Loading