Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offheap guard for OMR #7513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

midronij
Copy link
Contributor

@midronij midronij commented Oct 31, 2024

Use OMR_GC_SPARSE_HEAP_ALLOCATION instead of J9VM_GC_ENABLE_SPARSE_HEAP_ALLOCATION in setmemoryEvaluator().

@midronij
Copy link
Contributor Author

@amicic @0xdaryl @rmnattas I've separated the offheap macro fix into this PR. The change is very simple so hopefully we can merge it soon

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 31, 2024

Jenkins build plinux,aix

@0xdaryl 0xdaryl self-assigned this Oct 31, 2024
@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 31, 2024

@midronij : please see the CI build failures

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 31, 2024

Jenkins build plinux,aix

@midronij
Copy link
Contributor Author

I believe the CI failures are happening because my change is dependent on this PR: eclipse-openj9/openj9#20461. I've updated the title/description accordingly

@amicic
Copy link
Contributor

amicic commented Oct 31, 2024

I believe the CI failures are happening because my change is dependent on this PR: eclipse-openj9/openj9#20461. I've updated the title/description accordingly

There should not ever be dependancy from OMR code on J9 (or potentially any other downstream project). OMR should be able to compile standalone. You might be missing some 'empty' methods in OMR that J9 fully implement

@amicic
Copy link
Contributor

amicic commented Oct 31, 2024

for the failures of missing compressObjectReferences, follow an example of contiguousArrayHeaderSizeInBytes()

Use OMR_GC_SPARSE_HEAP_ALLOCATION instead of
J9VM_GC_ENABLE_SPARSE_HEAP_ALLOCATION in setmemoryEvaluator.

Signed-off-by: midronij <[email protected]>
@midronij
Copy link
Contributor Author

midronij commented Nov 6, 2024

@0xdaryl I rebased my branch and I'm now able to build sucessfully. When you have a moment can you please run the CI tests again?

@0xdaryl
Copy link
Contributor

0xdaryl commented Nov 6, 2024

Jenkins build plinux,aix

@0xdaryl
Copy link
Contributor

0xdaryl commented Nov 6, 2024

There are still failures in the CI builds. When you said that your build was successful, was that an OpenJ9 build?

The compilers these CI builds are building and testing are either "compilertest" builds or "jitbuilder" builds. These are not connected to OpenJ9 at all.

To reproduce this locally, if you look at your failed AIX job you can see the "cmake" command that was used to prepare the build (near the beginning of the console output). Further CMake info is here -> https://github.com/eclipse-omr/omr/blob/master/doc/BuildingWithCMake.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants