Retire KeybindingContext Part 1
#12732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernandoAscencio
force-pushed
the
fa/RetireKeybindingContext
branch
7 times, most recently
from
7262a59
to
91f4d1e
Compare
FernandoAscencio
force-pushed
the
fa/RetireKeybindingContext
branch
2 times, most recently
from
18ab8ae
to
6e65e03
Compare
vince-fugnitto
added
keybindings
FernandoAscencio
force-pushed
the
fa/RetireKeybindingContext
branch
2 times, most recently
from
0ecb973
to
83877ec
Compare
The method did not properly set the visibility state of notifications. Thus, the context keys were not properly updated. Signed-Off-By: Fernando Ascencio <[email protected]>
- Retiring the use of `context` in keybindings - Eliminating implementations of `KeybindingContext` Signed-Off-By: Fernando Ascencio <[email protected]>
FernandoAscencio
force-pushed
the
fa/RetireKeybindingContext
branch
from
83877ec
to
252f0df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retiring the use of
contextin keybindingsThis is still in draft and review.
KeybindingContextclasses still exist in Theia, but no longer used.Needs some review to streamline
What it does
How to test
Review checklist
Reminder for reviewers