Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire KeybindingContext Part 1 #12732

Closed
wants to merge 2 commits into from
Closed

Retire KeybindingContext Part 1 #12732

wants to merge 2 commits into from

Commits on Aug 11, 2023

  1. This commit fixes a notification context issue 

    The method did not properly set the visibility state of notifications.
Thus, the context keys were not properly updated.

Signed-Off-By: Fernando Ascencio <[email protected]>
    @FernandoAscencio
    FernandoAscencio committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5e4d567 View commit details
    Browse the repository at this point in the history

  2. Retire KeybindingContext 

    - Retiring the use of `context` in keybindings
- Eliminating implementations of `KeybindingContext`

Signed-Off-By: Fernando Ascencio <[email protected]>
    @FernandoAscencio
    FernandoAscencio committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    252f0df View commit details
    Browse the repository at this point in the history