-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include runtime dependencies for emmet #22
Conversation
Fixes #18 Signed-off-by: Marc Dumais <[email protected]>
@marcdumais-work would it be harmful to do the same thing for all extensions as to not have any potential runtime dependencies issues? |
I'm fine as well with doing the update on a case-per-case basis as well if that's the strategy. |
@vince-fugnitto we could check whether package.json has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcdumais-work I verified the changes and I now see emmet
snippets being successfully contributed and suggested when editing html files. I also no longer see the frontend error reported.
I do not think it would be harmful, and Anton's suggestion of narrowing it down to extensions that have runtime dependencies could be even better. However I am hesitant to do this right now since I do not have much time to properly test all affected built-ins. I've opened an issue instead for now: #23 |
@akosyakov are you fine with me merging this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine :)
Fixes #18
As suggested here, I added one step to install the production dependencies for emmet: #18 (comment)
It seems to fix #18 and as well make the emmet built-in work: see second video here: #18 (comment)
How to test
Build this branch using yarn, then test the emmet built-in as per the following comment, and verify that this scenario no longer generates an exception: #18 (comment)