Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor erp adapter request type #584

Closed
Tracked by #419
tom-rm-meyer-ISST opened this issue Sep 11, 2024 · 0 comments · Fixed by #578
Closed
Tracked by #419

Refactor erp adapter request type #584

tom-rm-meyer-ISST opened this issue Sep 11, 2024 · 0 comments · Fixed by #578

Comments

@tom-rm-meyer-ISST
Copy link
Contributor

tom-rm-meyer-ISST commented Sep 11, 2024 •
edited
Loading

As Developer,
I want to clean up the ErpAdapterService,
so that we don't have technical debts.

Hints / Details

See findings in acceptance criteria

Outcome / Acceptance Criteria

Outcome

  • ...

Acceptance Criteria

  • DataInjectionCommandLineRunner: remove mock request
  • ErpAdapterController: add status codes 500 for any server side issue, 400 for bad request
  • Double check that there is a test for the existing mapper if materialGlobalAssetId is empty
  • Align content of ErpAdapterRequest.requestType and add it as enumeration (with one entry), also check for version

Out of Scope

  • ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: cleanup erpadapterrequest FraunhoferISST/puris
1 participant
@tom-rm-meyer-ISST