Remove merge queue from query is feature is disabled

[ejoffe]

fixes #356

commit-id:0219e1da

[pleicht]

Thanks a bunch for making this change! I think the condition for when to add the MergeQueue to the operation string needs to be inverted

[pleicht]

Same here with inverting condition

Suggested change

	mergeQueueEntry @skip(if: $use_merge_queue) {
	mergeQueueEntry @skip(if: !$use_merge_queue) {

[pleicht]

I think the condition needs to be inverted

Suggested change

	mergeQueueEntry @skip(if: $use_merge_queue) {
	mergeQueueEntry @skip(if: !$use_merge_queue) {

[pleicht]

This file is probably generated from the above. Still completely new to Go

[ejoffe]

Ah, you are correct. My bad. Will flip it.

[pleicht]

Looks right to me. The condition is to skip this field if use_merge_queue == true.

I tested it locally when building this branch and I get the error for merge queue. I think we only want to generate the MergeQueue section if use_merge_queue is true, if false we exclude

[ejoffe]

Should be correct now. Good catch.

[pleicht]

Not sure if I'm doing something wrong with my local build, but I'm getting:

panic: query PullRequests.viewer.pullRequests.nodes.mergeQueueEntry: Field 'mergeQueueEntry' doesn't exist on type 'PullRequest'
query PullRequests: Variable $no_merge_queue is declared by PullRequests but not used

[ejoffe]

I guess the skip directive doesn't work in this case, will try another approach.

[pleicht]

I guess the skip directive doesn't work in this case, will try another approach.

👍, thanks for the help and spr in general, I really enjoy using it!

[ejoffe]

Much more involved fix pushed. I think this one should work for you. Let me know.

[pleicht]

Tested and confirmed it is working for me. Thanks!