Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy span.id to documents with transaction.id #112

Merged
merged 9 commits into from
Jul 19, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Jul 12, 2023

Fixes #82

Needs elastic/apm-server#11201 in apm-server to be actually used. modifying the intake parts allows to avoid this.

@SylvainJuge SylvainJuge self-assigned this Jul 12, 2023
@SylvainJuge SylvainJuge marked this pull request as ready for review July 12, 2023 16:01
@SylvainJuge SylvainJuge requested a review from a team as a code owner July 12, 2023 16:01
Copy link
Member

@kruskall kruskall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor comment

model/modelprocessor/transaction_span_id.go Outdated Show resolved Hide resolved
@kruskall
Copy link
Member

For the lint error: I think make update-licenses should fix the issue

input/otlp/traces.go Outdated Show resolved Hide resolved
@simitt
Copy link
Contributor

simitt commented Jul 19, 2023

Looks like @SylvainJuge is out for a bit; @kruskall it looks like all your comments, were addressed - could you push this over the finish line please.

@kruskall kruskall merged commit 88a3977 into elastic:main Jul 19, 2023
2 checks passed
@kruskall
Copy link
Member

Done! Thanks for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add span.id field to transactions
3 participants