Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add span.id to documents with transaction.id #11201

Closed
wants to merge 2 commits into from

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Jul 12, 2023

Motivation/summary

Adds span.id for the documents that already have a transaction.id in order to allow referencing transactions AND spans by using a single span.id field.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

depends on elastic/apm-data#112

Related issues

elastic/apm-data#82

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

This pull request does not have a backport label. Could you fix it @SylvainJuge? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jul 12, 2023
@apmmachine
Copy link
Contributor

apmmachine commented Jul 12, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-12T16:00:34.220+0000

  • Duration: 11 min 39 sec

Steps errors 3

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/apm-server.yml
Run benchmarks
  • Took 2 min 24 sec . View more details here
  • Description: ./.ci/scripts/bench.sh
Recursively delete the current directory from the workspace
  • Took 0 min 1 sec . View more details here
  • Description: script returned exit code 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge self-assigned this Jul 12, 2023
@SylvainJuge SylvainJuge requested a review from a team July 12, 2023 15:59
@SylvainJuge SylvainJuge marked this pull request as ready for review July 12, 2023 16:01
@SylvainJuge
Copy link
Member Author

Closing this as another approach was taken in elastic/apm-data#112 which does not requires changes in apm-server by modifying only the intake parts (both otlp and elastic).

@SylvainJuge SylvainJuge deleted the add-transaction-span-id branch July 13, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants