-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/input/entityanalytics/provider/okta/internal/okta: add device handling #35980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Filebeat
Filebeat
Team:Security-External Integrations
backport-skip
Skip notification from the automated backport with mergify
8.10-candidate
labels
Jul 3, 2023
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jul 3, 2023
efd6
force-pushed
the
st6908-okta-device
branch
3 times, most recently
from
July 3, 2023 02:45
a2d55e3
to
04ed269
Compare
Collaborator
6 tasks
efd6
force-pushed
the
st6908-okta-device
branch
2 times, most recently
from
July 14, 2023 01:42
8d64c9b
to
7004ea2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
efd6
force-pushed
the
st6908-okta-device
branch
2 times, most recently
from
July 23, 2023 22:13
e208394
to
5423243
Compare
This comment was marked as outdated.
This comment was marked as outdated.
efd6
force-pushed
the
st6908-okta-device
branch
from
August 7, 2023 22:11
8f05b8f
to
b27f4f9
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
force-pushed
the
st6908-okta-device
branch
from
August 8, 2023 00:24
b27f4f9
to
e05d847
Compare
…d device handling WIP: needs validation against real API.
efd6
force-pushed
the
st6908-okta-device
branch
from
August 8, 2023 03:59
e05d847
to
b60c9c6
Compare
ShourieG
reviewed
Aug 10, 2023
x-pack/filebeat/input/entityanalytics/provider/okta/internal/okta/okta_test.go
Show resolved
Hide resolved
ShourieG
reviewed
Aug 10, 2023
x-pack/filebeat/input/entityanalytics/provider/okta/internal/okta/okta.go
Show resolved
Hide resolved
I know the lint errors are being caused by existing code, but would be nice to clean them up if possible. |
I'd rather not degrade the legibility of the code to make a linter happy. |
ShourieG
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…d device handling (elastic#35980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.10-candidate
backport-skip
Skip notification from the automated backport with mergify
Filebeat
Filebeat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds support for device entities to the Okta API entity analytics provider.
Why is it important?
Milestone task.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
OKTA_HOST=dev-<nnnnnnn>-admin.okta.com OKTA_TOKEN=<token> go test -log_response -v -run Test/device
using your Okta domain and API token.You should see something like this (details sanitised here):
Related issues
Use cases
Screenshots
Logs