golangci.yml: silence invalid linter complaints on use of logp.TestingSetup #36474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gSetup A logp.TestingSetup call can only fail when no logp.ToObserverOutput() option has been provided and one of syslog, file or event log output has been selected. There is no case in the code base where this is true. So disable the errcheck linter for this function. The only way that the function can return an error is when a user makes use of a custom logp.Option function since none of the provided Options alter the logp.Config to cause output to failable destinations.
efd6
added
enhancement
Team:Security-External Integrations
backport-skip
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
6 tasks
rdner
approved these changes
Aug 31, 2023
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…gSetup (elastic#36474) A logp.TestingSetup call can only fail when no logp.ToObserverOutput() option has been provided and one of syslog, file or event log output has been selected. There is no case in the code base where this is true. So disable the errcheck linter for this function. The only way that the function can return an error is when a user makes use of a custom logp.Option function since none of the provided Options alter the logp.Config to cause output to failable destinations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
A
logp.TestingSetupcall can only fail when nologp.ToObserverOutput()option has been provided and one of syslog, file or event log output has been selected. There is no case in the code base where this is true. So disable the errcheck linter for this function.The only way that the function can return an error is when a user makes use of a custom
logp.Optionfunction since none of the providedOptions alter the logp.Config to cause output to failable destinations.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs